[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.12 08/12] qemu-iotests: Test parallels ima
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP |
Date: |
Wed, 21 Mar 2018 18:21:15 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 20.03.2018 um 19:42 hat Eric Blake geschrieben:
> On 03/20/2018 12:36 PM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/212 | 326
> > +++++++++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/212.out | 111 +++++++++++++++
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 438 insertions(+)
> > create mode 100755 tests/qemu-iotests/212
> > create mode 100644 tests/qemu-iotests/212.out
> >
>
> > +echo
> > +echo "=== Invalid sizes ==="
> > +echo
> > +
> > +# TODO Negative image sizes aren't handled correctly, but this is a problem
> > +# with QAPI's implementation of the 'size' type and affects other commands
> > as
> > +# well. Once this is fixed, we may want to add a test case here.
> > +
> > +# 1. Misaligned image size
> > +# 2. 2^64 - 512
> > +# 3. 2^63 = 8 EB (qemu-img enforces image sizes less than this)
> > +# 4. 2^63 - 512 (generally valid, but with the crypto header the file will
> > +# exceed 63 bits)
>
> Is this part of the comment stale copy-and-paste? There's no crypto header,
> and the real max is much smaller...
Yeah... Not sure if the case is all that useful, but it can't hurt, so
I'll just s/crypto header/image header/ rather than removing it.
Kevin
- Re: [Qemu-block] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check, (continued)
- [Qemu-block] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 11/12] vhdx: Check for 4 GB maximum log size on creation, Kevin Wolf, 2018/03/20
- [Qemu-block] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP, Kevin Wolf, 2018/03/20