[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-ppc] [PATCH v2 3/5] error: Remove NULL checks on
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [Qemu-ppc] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls |
Date: |
Fri, 23 Mar 2018 20:14:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 23.03.2018 15:32, Laurent Vivier wrote:
> Re-run Coccinelle patch
> scripts/coccinelle/error_propagate_null.cocci
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> io/channel-websock.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index ec48a305f0..e6608b969d 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -586,9 +586,7 @@ static gboolean
> qio_channel_websock_handshake_io(QIOChannel *ioc,
> return TRUE;
> }
>
> - if (err) {
> - error_propagate(&wioc->io_err, err);
> - }
> + error_propagate(&wioc->io_err, err);
>
> trace_qio_channel_websock_handshake_reply(ioc);
> qio_channel_add_watch(
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-block] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle, Laurent Vivier, 2018/03/23
- [Qemu-block] [PATCH v2 1/5] make: improve check for stale generated files in source dir, Laurent Vivier, 2018/03/23
- [Qemu-block] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls, Laurent Vivier, 2018/03/23
- Re: [Qemu-block] [Qemu-ppc] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls,
Thomas Huth <=
- [Qemu-block] [PATCH v2 2/5] error: Strip trailing '\n' from error string arguments (again again), Laurent Vivier, 2018/03/23
- [Qemu-block] [PATCH v2 4/5] qdict: remove useless cast, Laurent Vivier, 2018/03/23
- [Qemu-block] [PATCH v2 5/5] Remove unnecessary variables for function return value, Laurent Vivier, 2018/03/23
- Re: [Qemu-block] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle, Eric Blake, 2018/03/23
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle, no-reply, 2018/03/24