Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/5] coccinelle: re-run scripts from 
scripts/coccinelle

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
84a0e34b6c Remove unnecessary variables for function return value
17594118dc qdict: remove useless cast
92e0e646c2 error: Remove NULL checks on error_propagate() calls
d34ed23173 error: Strip trailing '\n' from error string arguments (again again)
a1d1581ad5 make: improve check for stale generated files in source dir

=== OUTPUT BEGIN ===
Checking PATCH 1/5: make: improve check for stale generated files in source 
dir...
Checking PATCH 2/5: error: Strip trailing '\n' from error string arguments 
(again again)...
Checking PATCH 3/5: error: Remove NULL checks on error_propagate() calls...
Checking PATCH 4/5: qdict: remove useless cast...
Checking PATCH 5/5: Remove unnecessary variables for function return value...
ERROR: return is not a function, parentheses are not required
#253: FILE: target/mips/dsp_helper.c:3281:
+    return (temp[1] << 63) | (temp[0] >> 1);

ERROR: return is not a function, parentheses are not required
#272: FILE: target/mips/dsp_helper.c:3308:
+    return (temp[1] << 63) | (temp[0] >> 1);

ERROR: return is not a function, parentheses are not required
#291: FILE: target/mips/dsp_helper.c:3341:
+    return (temp[1] << 63) | (temp[0] >> 1);

total: 3 errors, 0 warnings, 817 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden