[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/11] image-fuzzer: Open image files in binary mode
From: |
Stefan Hajnoczi |
Subject: |
[PULL 01/11] image-fuzzer: Open image files in binary mode |
Date: |
Tue, 5 Nov 2019 16:43:22 +0100 |
From: Eduardo Habkost <address@hidden>
This probably never caused problems because on Linux there's no
actual newline conversion happening, but on Python 3 the
binary/text distinction is stronger and we must explicitly open
the image file in binary mode.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/image-fuzzer/qcow2/layout.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py
b/tests/image-fuzzer/qcow2/layout.py
index 675877da96..c57418fa15 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -503,7 +503,7 @@ class Image(object):
def write(self, filename):
"""Write an entire image to the file."""
- image_file = open(filename, 'w')
+ image_file = open(filename, 'wb')
for field in self:
image_file.seek(field.offset)
image_file.write(struct.pack(field.fmt, field.value))
--
2.23.0
- [PULL 00/11] Block patches, Stefan Hajnoczi, 2019/11/05
- [PULL 01/11] image-fuzzer: Open image files in binary mode,
Stefan Hajnoczi <=
- [PULL 02/11] image-fuzzer: Write bytes instead of string to image file, Stefan Hajnoczi, 2019/11/05
- [PULL 03/11] image-fuzzer: Explicitly use integer division operator, Stefan Hajnoczi, 2019/11/05
- [PULL 04/11] image-fuzzer: Use io.StringIO, Stefan Hajnoczi, 2019/11/05
- [PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__(), Stefan Hajnoczi, 2019/11/05
- [PULL 06/11] image-fuzzer: Return bytes objects on string fuzzing functions, Stefan Hajnoczi, 2019/11/05
- [PULL 07/11] image-fuzzer: Use bytes constant for field values, Stefan Hajnoczi, 2019/11/05
- [PULL 08/11] image-fuzzer: Encode file name and file format to bytes, Stefan Hajnoczi, 2019/11/05
- [PULL 09/11] image-fuzzer: Run using python3, Stefan Hajnoczi, 2019/11/05
- [PULL 10/11] image-fuzzer: Use errors parameter of subprocess.Popen(), Stefan Hajnoczi, 2019/11/05
- [PULL 11/11] image-fuzzer: Use OSerror.strerror instead of tuple subscript, Stefan Hajnoczi, 2019/11/05