[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__()
From: |
Stefan Hajnoczi |
Subject: |
[PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__() |
Date: |
Tue, 5 Nov 2019 16:43:26 +0100 |
From: Eduardo Habkost <address@hidden>
This makes the formatting code simpler, and safer if we change
the type of self.value from str to bytes.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/image-fuzzer/qcow2/layout.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py
b/tests/image-fuzzer/qcow2/layout.py
index 6501c9fd4b..0adcbd448d 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -53,8 +53,8 @@ class Field(object):
return iter([self.fmt, self.offset, self.value, self.name])
def __repr__(self):
- return "Field(fmt='%s', offset=%d, value=%s, name=%s)" % \
- (self.fmt, self.offset, str(self.value), self.name)
+ return "Field(fmt=%r, offset=%r, value=%r, name=%r)" % \
+ (self.fmt, self.offset, self.value, self.name)
class FieldsList(object):
--
2.23.0
- [PULL 00/11] Block patches, Stefan Hajnoczi, 2019/11/05
- [PULL 01/11] image-fuzzer: Open image files in binary mode, Stefan Hajnoczi, 2019/11/05
- [PULL 02/11] image-fuzzer: Write bytes instead of string to image file, Stefan Hajnoczi, 2019/11/05
- [PULL 03/11] image-fuzzer: Explicitly use integer division operator, Stefan Hajnoczi, 2019/11/05
- [PULL 04/11] image-fuzzer: Use io.StringIO, Stefan Hajnoczi, 2019/11/05
- [PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__(),
Stefan Hajnoczi <=
- [PULL 06/11] image-fuzzer: Return bytes objects on string fuzzing functions, Stefan Hajnoczi, 2019/11/05
- [PULL 07/11] image-fuzzer: Use bytes constant for field values, Stefan Hajnoczi, 2019/11/05
- [PULL 08/11] image-fuzzer: Encode file name and file format to bytes, Stefan Hajnoczi, 2019/11/05
- [PULL 09/11] image-fuzzer: Run using python3, Stefan Hajnoczi, 2019/11/05
- [PULL 10/11] image-fuzzer: Use errors parameter of subprocess.Popen(), Stefan Hajnoczi, 2019/11/05
- [PULL 11/11] image-fuzzer: Use OSerror.strerror instead of tuple subscript, Stefan Hajnoczi, 2019/11/05
- Re: [PULL 00/11] Block patches, Peter Maydell, 2019/11/06