[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment
From: |
Alistair Francis |
Subject: |
Re: [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment |
Date: |
Mon, 23 Mar 2020 08:50:13 -0700 |
On Sat, Mar 21, 2020 at 7:45 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/i2c/pm_smbus.o
> hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/i2c/pm_smbus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
> index 36994ff585..4728540c37 100644
> --- a/hw/i2c/pm_smbus.c
> +++ b/hw/i2c/pm_smbus.c
> @@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s)
> s->smb_stat |= STS_HOST_BUSY | STS_BYTE_DONE;
> s->smb_data[0] = s->smb_blkdata;
> s->smb_index = 0;
> - ret = 0;
> }
> goto out;
> }
> --
> 2.21.1
>
>
- [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 01/11] block: Avoid dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 02/11] blockdev: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment,
Alistair Francis <=
- [PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 05/11] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 06/11] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments, Philippe Mathieu-Daudé, 2020/03/21