[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assign
From: |
Alistair Francis |
Subject: |
Re: [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments |
Date: |
Mon, 23 Mar 2020 08:52:30 -0700 |
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Fix warnings reported by Clang static code analyzer:
>
> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never
> read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never
> read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never
> read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/timer/exynos4210_mct.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
> index 944120aea5..c0a25e71ec 100644
> --- a/hw/timer/exynos4210_mct.c
> +++ b/hw/timer/exynos4210_mct.c
> @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr
> offset,
>
> case L0_TCNTB: case L1_TCNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>
> /*
> * TCNTB is updated to internal register only after CNT expired.
> @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr
> offset,
>
> case L0_ICNTB: case L1_ICNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>
> s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
> s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
> @@ -1438,7 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr
> offset,
>
> case L0_FRCNTB: case L1_FRCNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>
> DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
>
> --
> 2.21.1
>
>
- Re: [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment, (continued)
- [PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 05/11] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 06/11] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments,
Alistair Francis <=
- [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Laurent Vivier, 2020/03/23