[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] migration/colo: fix use after free of local_err
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 4/6] migration/colo: fix use after free of local_err |
Date: |
Tue, 24 Mar 2020 18:36:28 +0300 |
local_err is used again in secondary_vm_do_failover() after
replication_stop_all(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
migration/colo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/colo.c b/migration/colo.c
index 44942c4e23..a54ac84f41 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void)
replication_stop_all(true, &local_err);
if (local_err) {
error_report_err(local_err);
+ local_err = NULL;
}
/* Notify all filters of all NIC to do checkpoint */
--
2.21.0
[PATCH 4/6] migration/colo: fix use after free of local_err,
Vladimir Sementsov-Ogievskiy <=
[PATCH 3/6] dump/win_dump: fix use after free of err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 5/6] migration/ram: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 6/6] qga/commands-posix: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24