[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] migration/ram: fix use after free of local_err
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 5/6] migration/ram: fix use after free of local_err |
Date: |
Tue, 24 Mar 2020 19:41:54 +0000 |
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* Vladimir Sementsov-Ogievskiy (address@hidden) wrote:
> local_err is used again in migration_bitmap_sync_precopy() after
> precopy_notify(), so we must zero it. Otherwise try to set
> non-NULL local_err will crash.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> migration/ram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index c12cfdbe26..04f13feb2e 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -980,6 +980,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs)
> */
> if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) {
> error_report_err(local_err);
> + local_err = NULL;
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
and queued.
> }
>
> migration_bitmap_sync(rs);
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [PATCH 2/6] block/mirror: fix use after free of local_err, (continued)
- [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci, Vladimir Sementsov-Ogievskiy, 2020/03/24
- [PATCH 4/6] migration/colo: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
- [PATCH 3/6] dump/win_dump: fix use after free of err, Vladimir Sementsov-Ogievskiy, 2020/03/24
- [PATCH 5/6] migration/ram: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
- Re: [PATCH 5/6] migration/ram: fix use after free of local_err,
Dr. David Alan Gilbert <=
- [PATCH 6/6] qga/commands-posix: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
- Re: [PATCH 6/6] qga/commands-posix: fix use after free of local_err, Markus Armbruster, 2020/03/31
Re: [PATCH for-5.0 0/6] Several error use-after-free, Richard Henderson, 2020/03/24