[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/9] block/vpc: Use sizeof() instead of 1024 for dynamic header s
From: |
Markus Armbruster |
Subject: |
[PATCH 6/9] block/vpc: Use sizeof() instead of 1024 for dynamic header size |
Date: |
Thu, 17 Dec 2020 17:20:00 +0100 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
block/vpc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 08a0f710ad..6cb656ac82 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -344,7 +344,7 @@ static int vpc_open(BlockDriverState *bs, QDict *options,
int flags,
if (disk_type == VHD_DYNAMIC) {
ret = bdrv_pread(bs->file, be64_to_cpu(footer->data_offset),
- &dyndisk_header, 1024);
+ &dyndisk_header, sizeof(dyndisk_header));
if (ret < 0) {
error_setg(errp, "Error reading dynamic VHD header");
goto fail;
@@ -858,7 +858,7 @@ static int create_dynamic_disk(BlockBackend *blk, uint8_t
*buf,
}
/* Prepare the Dynamic Disk Header */
- memset(&dyndisk_header, 0, 1024);
+ memset(&dyndisk_header, 0, sizeof(dyndisk_header));
memcpy(dyndisk_header.magic, "cxsparse", 8);
@@ -872,12 +872,13 @@ static int create_dynamic_disk(BlockBackend *blk, uint8_t
*buf,
dyndisk_header.block_size = cpu_to_be32(block_size);
dyndisk_header.max_table_entries = cpu_to_be32(num_bat_entries);
- dyndisk_header.checksum = cpu_to_be32(vpc_checksum(&dyndisk_header, 1024));
+ dyndisk_header.checksum = cpu_to_be32(
+ vpc_checksum(&dyndisk_header, sizeof(dyndisk_header)));
/* Write the header */
offset = 512;
- ret = blk_pwrite(blk, offset, &dyndisk_header, 1024, 0);
+ ret = blk_pwrite(blk, offset, &dyndisk_header, sizeof(dyndisk_header), 0);
if (ret < 0) {
goto fail;
}
--
2.26.2
- [PATCH 0/9] block/vpc: Clean up some buffer abuse, Markus Armbruster, 2020/12/17
- [PATCH 3/9] block/vpc: Don't abuse the footer buffer for dynamic header, Markus Armbruster, 2020/12/17
- [PATCH 2/9] block/vpc: Don't abuse the footer buffer as BAT sector buffer, Markus Armbruster, 2020/12/17
- [PATCH 4/9] block/vpc: Make vpc_checksum() take void *, Markus Armbruster, 2020/12/17
- [PATCH 6/9] block/vpc: Use sizeof() instead of 1024 for dynamic header size,
Markus Armbruster <=
- [PATCH 8/9] block/vpc: Pass footer buffers as VHDFooter * instead of uint8_t *, Markus Armbruster, 2020/12/17
- [PATCH 7/9] block/vpc: Pad VHDFooter, replace uint8_t[] buffers, Markus Armbruster, 2020/12/17
- [PATCH 5/9] block/vpc: Pad VHDDynDiskHeader, replace uint8_t[] buffers, Markus Armbruster, 2020/12/17
- [PATCH 9/9] block/vpc: Use sizeof() instead of HEADER_SIZE for footer size, Markus Armbruster, 2020/12/17
- [PATCH 1/9] block/vpc: Make vpc_open() read the full dynamic header, Markus Armbruster, 2020/12/17