[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] block/vpc: Make vpc_checksum() take void *
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 4/9] block/vpc: Make vpc_checksum() take void * |
Date: |
Fri, 18 Dec 2020 14:54:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Max Reitz <mreitz@redhat.com> writes:
> On 17.12.20 17:19, Markus Armbruster wrote:
>> Some of the next commits will checksum structs. Change vpc_checksum()
>> to take void * instead of uint8_t, to save us pointless casts to
>> uint8_t *.
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> block/vpc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/block/vpc.c b/block/vpc.c
>> index 34186640ee..5af9837806 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -172,8 +172,9 @@ static QemuOptsList vpc_runtime_opts = {
>> static QemuOptsList vpc_create_opts;
>> -static uint32_t vpc_checksum(uint8_t *buf, size_t size)
>> +static uint32_t vpc_checksum(void *p, size_t size)
>> {
>> + uint8_t *buf = p;
>> uint32_t res = 0;
>> int i;
>
> Using this opportunity to add consts would be nice, but not necessary:
Didn't think of it, missed opportunity. Not worth a respin all by
itself, I think. I'm fine with the maintainer adding const.
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Thanks!
- [PATCH 0/9] block/vpc: Clean up some buffer abuse, Markus Armbruster, 2020/12/17
- [PATCH 3/9] block/vpc: Don't abuse the footer buffer for dynamic header, Markus Armbruster, 2020/12/17
- [PATCH 2/9] block/vpc: Don't abuse the footer buffer as BAT sector buffer, Markus Armbruster, 2020/12/17
- [PATCH 4/9] block/vpc: Make vpc_checksum() take void *, Markus Armbruster, 2020/12/17
- [PATCH 6/9] block/vpc: Use sizeof() instead of 1024 for dynamic header size, Markus Armbruster, 2020/12/17
- [PATCH 8/9] block/vpc: Pass footer buffers as VHDFooter * instead of uint8_t *, Markus Armbruster, 2020/12/17
- [PATCH 7/9] block/vpc: Pad VHDFooter, replace uint8_t[] buffers, Markus Armbruster, 2020/12/17
- [PATCH 5/9] block/vpc: Pad VHDDynDiskHeader, replace uint8_t[] buffers, Markus Armbruster, 2020/12/17
- [PATCH 9/9] block/vpc: Use sizeof() instead of HEADER_SIZE for footer size, Markus Armbruster, 2020/12/17