Re: [PATCH v6 10/11] iotests: rewrite check into python

[Kevin Wolf]

Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Just use classes introduced in previous three commits. Behavior
> difference is described in these three commits.
> 
> Drop group file, as it becomes unused.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/check | 994 ++-------------------------------------
>  tests/qemu-iotests/group | 321 -------------
>  2 files changed, 28 insertions(+), 1287 deletions(-)
>  delete mode 100644 tests/qemu-iotests/group

> +import sys
> +import os
> +from findtests import find_tests, TestFinder
> +from testenv import TestEnv
> +from testrunner import TestRunner
> +
> +if __name__ == '__main__':
> +    if len(sys.argv) == 2 and sys.argv[1] in ['-h', '--help']:
> +        print('Usage: ./check [options] [testlist]')
> +        print()
> +        TestFinder.get_argparser().print_help()
> +        print()
> +        TestEnv.get_argparser().print_help()
> +        print()
> +        TestRunner.get_argparser().print_help()
> +        exit()

+check:34:8: R1722: Consider using sys.exit() (consider-using-sys-exit)

> +
> +    env = TestEnv(sys.argv[1:])
> +    tests, remaining_argv = find_tests(env.remaining_argv,
> +                                       test_dir=env.source_iotests)
> +
> +    with TestRunner(remaining_argv, env) as tr:
> +        assert not tr.remaining_argv
> +        tr.run_tests([os.path.join(env.source_iotests, t) for t in tests])

The assertion means that giving an unknown option results in an error
message like this:

$ build/check -T -raw
Traceback (most recent call last):
  File "/home/kwolf/source/qemu/tests/qemu-iotests/build/check", line 41, in 
<module>
    assert not tr.remaining_argv
AssertionError

I think this could be a bit friendlier (especially since this doesn't
even tell you which of your options was wrong).

Kevin