[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running |
Date: |
Wed, 13 Jan 2021 16:38:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> If you run './check 303', check includes common.config which adjusts
> $PATH to include '.' first, and therefore finds qcow2.py on PATH. But
> if you run './303' directly, there is nothing to adjust PATH, and if
> '.' is not already on your PATH by other means, the test fails because
> the executable is not found. Adjust how we invoke the helper
> executable to avoid needing a PATH search in the first place.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/303 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303
> index 6c21774483..11cd9eeb26 100755
> --- a/tests/qemu-iotests/303
> +++ b/tests/qemu-iotests/303
> @@ -56,7 +56,7 @@ qemu_img_create('-f', iotests.imgfmt, disk, '10M')
>
> add_bitmap(1, 0, 6, False)
> add_bitmap(2, 6, 8, True)
> -dump = ['qcow2.py', disk, 'dump-header']
> +dump = ['./qcow2.py', disk, 'dump-header']
> subprocess.run(dump)
> # Dump the metadata in JSON format
> dump.append('-j')
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 00/11] Rework iotests/check, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 09/11] iotests: add testrunner.py, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running, Vladimir Sementsov-Ogievskiy, 2021/01/09
- Re: [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running,
Eric Blake <=
- [PATCH v6 10/11] iotests: rewrite check into python, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 03/11] iotests: fix some whitespaces in test output files, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 04/11] iotests: make tests executable, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 05/11] iotests/294: add shebang line, Vladimir Sementsov-Ogievskiy, 2021/01/09