[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() |
Date: |
Wed, 10 Feb 2021 12:12:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
Hi Bin,
On 2/10/21 11:23 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Current QEMU HEAD nvme.c does not compile:
>
> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
> ^
> hw/block/nvme.c:3150:14: note: ‘result’ was declared here
> uint32_t result;
> ^
Why isn't this catched by our CI? What is your host OS? Fedora 33?
>
> Explicitly initialize the result to fix it.
>
> Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> ---
>
> Changes in v2:
> - update function name in the commit message
>
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)