[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()
From: |
Bin Meng |
Subject: |
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() |
Date: |
Wed, 10 Feb 2021 19:15:26 +0800 |
Hi Philippe,
On Wed, Feb 10, 2021 at 7:12 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Hi Bin,
>
> On 2/10/21 11:23 AM, Bin Meng wrote:
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > Current QEMU HEAD nvme.c does not compile:
> >
> > hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> > trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
> > ^
> > hw/block/nvme.c:3150:14: note: ‘result’ was declared here
> > uint32_t result;
> > ^
>
> Why isn't this catched by our CI? What is your host OS? Fedora 33?
>
I am using GCC 5.4 on Ubuntu 16.04. Please see some initial analysis
from Peter about why newer version GCC does not report it.
Regards,
Bin