Re: [PATCH v3 09/16] semihosting: Clean up global variable shadowing

[Thomas Huth]

On 04/10/2023 14.16, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Fix:
> >
> >    semihosting/config.c:134:49: error: declaration shadows a variable in the 
> > global scope [-Werror,-Wshadow]
> >    int qemu_semihosting_config_options(const char *optarg)
> >                                                    ^
> >    
> > /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14: 
> > note: previous declaration is here
> >    extern char *optarg;                    /* getopt(3) external
> >    variables */
>
> I'm going to assume the getopt.h is somehow swept up by osdep.h?
>
> Anyway:
>
> Acked-by: Alex Bennée <alex.bennee@linaro.org>

Could we maybe rather remove getopt.h from osdep.h instead of renaming this 
everywhere? getopt.h should only be required by some few files, so including 
this in osdep.h seems exaggerated, IMHO.

 Thomas