Re: [PATCH v3 05/16] plugins/loader: Clean up global variable shadowing

[Alex Bennée]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Fix:
>
>   include/qemu/plugin.h:245:54: error: declaration shadows a variable in the 
> global scope [-Werror,-Wshadow]
>   static inline void qemu_plugin_opt_parse(const char *optarg,
>                                                        ^
>   
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
>  note: previous declaration is here
>   extern char *optarg;                    /* getopt(3) external
>   variables */

My same raised eyebrows are how exactly getopt.h is getting included but
anyway:

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro