Re: [PATCH v3 01/16] hw/audio/soundhw: Clean up global variable shadowing

[Thomas Huth]

On 04/10/2023 14.00, Philippe Mathieu-Daudé wrote:
> Fix:
>
>    hw/audio/soundhw.c:86:33: error: declaration shadows a variable in the 
> global scope [-Werror,-Wshadow]
>    void select_soundhw(const char *optarg, const char *audiodev)
>                                    ^
>    
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14: 
> note: previous declaration is here
>    extern char *optarg;                    /* getopt(3) external variables */
>                 ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/audio/soundhw.h | 2 +-
>   hw/audio/soundhw.c         | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>