[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 01/15] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argum
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 01/15] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument |
Date: |
Fri, 6 Oct 2023 18:41:11 +0300 |
The argument is unused, let's drop it for now, as we are going to
refactor the interface and don't want to refactor unused things.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
python/qemu/qmp/legacy.py | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index e1e9383978..fe115e301c 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -195,20 +195,16 @@ def cmd_obj(self, qmp_cmd: QMPMessage) -> QMPMessage:
)
def cmd(self, name: str,
- args: Optional[Dict[str, object]] = None,
- cmd_id: Optional[object] = None) -> QMPMessage:
+ args: Optional[Dict[str, object]] = None) -> QMPMessage:
"""
Build a QMP command and send it to the QMP Monitor.
:param name: command name (string)
:param args: command arguments (dict)
- :param cmd_id: command id (dict, list, string or int)
"""
qmp_cmd: QMPMessage = {'execute': name}
if args:
qmp_cmd['arguments'] = args
- if cmd_id:
- qmp_cmd['id'] = cmd_id
return self.cmd_obj(qmp_cmd)
def command(self, cmd: str, **kwds: object) -> QMPReturnValue:
--
2.34.1
- [PATCH v7 00/15] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 01/15] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 02/15] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 04/15] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 07/15] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 05/15] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 08/15] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 09/15] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 10/15] iotests: drop some extra semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/06