[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd() |
Date: |
Fri, 6 Oct 2023 18:41:13 +0300 |
Here we don't expect a failure. In case of failure we'll crash on
trying to access ['return']. Better is to use .command() that clearly
raises on failure.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
scripts/cpu-x86-uarch-abi.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
index 82ff07582f..893afd1b35 100644
--- a/scripts/cpu-x86-uarch-abi.py
+++ b/scripts/cpu-x86-uarch-abi.py
@@ -69,7 +69,7 @@
shell = QEMUMonitorProtocol(sock)
shell.connect()
-models = shell.cmd("query-cpu-definitions")
+models = shell.command("query-cpu-definitions")
# These QMP props don't correspond to CPUID fatures
# so ignore them
@@ -85,7 +85,7 @@
names = []
-for model in models["return"]:
+for model in models:
if "alias-of" in model:
continue
names.append(model["name"])
@@ -93,12 +93,12 @@
models = {}
for name in sorted(names):
- cpu = shell.cmd("query-cpu-model-expansion",
- { "type": "static",
- "model": { "name": name }})
+ cpu = shell.command("query-cpu-model-expansion",
+ { "type": "static",
+ "model": { "name": name }})
got = {}
- for (feature, present) in cpu["return"]["model"]["props"].items():
+ for (feature, present) in cpu["model"]["props"].items():
if present and feature not in skip:
got[feature] = True
--
2.34.1
- [PATCH v7 00/15] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 01/15] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 02/15] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(),
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 04/15] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 07/15] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 05/15] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 08/15] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 09/15] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 10/15] iotests: drop some extra semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 06/15] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 11/15] iotests: drop some extra ** in qmp() call, Vladimir Sementsov-Ogievskiy, 2023/10/06