[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 06/15] python/machine.py: upgrade vm.cmd() method
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 06/15] python/machine.py: upgrade vm.cmd() method |
Date: |
Fri, 6 Oct 2023 18:41:16 +0300 |
The method is not popular in iotests, we prefer use vm.qmp() and then
check success by hand. But that's not optimal. To simplify movement to
vm.cmd() let's support same interface improvements like in vm.qmp().
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
python/qemu/machine/machine.py | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index c4e80544bd..352e15b074 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -698,13 +698,23 @@ def qmp(self, cmd: str,
return ret
def cmd(self, cmd: str,
- conv_keys: bool = True,
+ args_dict: Optional[Dict[str, object]] = None,
+ conv_keys: Optional[bool] = None,
**args: Any) -> QMPReturnValue:
"""
Invoke a QMP command.
On success return the response dict.
On failure raise an exception.
"""
+ if args_dict is not None:
+ assert not args
+ assert conv_keys is None
+ args = args_dict
+ conv_keys = False
+
+ if conv_keys is None:
+ conv_keys = True
+
qmp_args = self._qmp_args(conv_keys, args)
ret = self._qmp.cmd(cmd, **qmp_args)
if cmd == 'quit':
--
2.34.1
- [PATCH v7 02/15] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), (continued)
- [PATCH v7 02/15] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 04/15] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 07/15] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 05/15] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 08/15] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 09/15] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 10/15] iotests: drop some extra semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 06/15] python/machine.py: upgrade vm.cmd() method,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 11/15] iotests: drop some extra ** in qmp() call, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 12/15] iotests.py: pause_job(): drop return value, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 13/15] tests/vm/basevm.py: use cmd() instead of qmp(), Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 14/15] scripts: add python_qmp_updater.py, Vladimir Sementsov-Ogievskiy, 2023/10/06
- [PATCH v7 15/15] python: use vm.cmd() instead of vm.qmp() where appropriate, Vladimir Sementsov-Ogievskiy, 2023/10/06
- Re: [PATCH v7 00/15] iotests: use vm.cmd(), John Snow, 2023/10/11