Re: [PATCH] tests/cdrom-test: Add cdrom test for LoongArch virt machine

[maobibo]

Hi Philippe,

On 2024/2/5 下午8:58, Philippe Mathieu-Daudé wrote:
> Hi Bibo,
>
> On 5/2/24 03:13, Bibo Mao wrote:
> > The cdrom test skips to execute on LoongArch system with command
> > "make check", this patch enables cdrom test for LoongArch virt
> > machine platform.
> >
> > With this patch, cdrom test passes to run on LoongArch virt
> > machine type.
> >
> > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> > ---
> >   tests/qtest/cdrom-test.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
> > index 0945383789..c8b97d8d9a 100644
> > --- a/tests/qtest/cdrom-test.c
> > +++ b/tests/qtest/cdrom-test.c
> > @@ -271,6 +271,9 @@ int main(int argc, char **argv)
> >               const char *virtmachine[] = { "virt", NULL };
> >               add_cdrom_param_tests(virtmachine);
> >           }
> > +    } else if (g_str_equal(arch, "loongarch64")) {
> > +        const char *virtmachine[] = { "virt", NULL };
> > +        add_cdrom_param_tests(virtmachine);
>
> What is the default device used, virtio-blk-pci?
yes, it is. For virt machine type, the default type for block device is
virtio interface, and it is defined at function loongarch_class_init().
   mc->block_default_type = IF_VIRTIO

Regards
Bibo Mao