Re: [PATCH] tests/cdrom-test: Add cdrom test for LoongArch virt machine

[maobibo]

Hi Thomas,

On 2024/2/5 下午3:47, Thomas Huth wrote:
> On 05/02/2024 03.13, Bibo Mao wrote:
> > The cdrom test skips to execute on LoongArch system with command
> > "make check"
>
> Are you sure the test is marked with "skip"? ... it should at least test 
> with the "none" machine...?
I check again, cdrom test case passes to run with "none" machine. And 
the root cause is that xorriso rpm package is missing so it is skipped.

Regards
Bibo Mao

> > this patch enables cdrom test for LoongArch virt
> > machine platform.
> >
> > With this patch, cdrom test passes to run on LoongArch virt
> > machine type.
> >
> > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> > ---
> >   tests/qtest/cdrom-test.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
> > index 0945383789..c8b97d8d9a 100644
> > --- a/tests/qtest/cdrom-test.c
> > +++ b/tests/qtest/cdrom-test.c
> > @@ -271,6 +271,9 @@ int main(int argc, char **argv)
> >               const char *virtmachine[] = { "virt", NULL };
> >               add_cdrom_param_tests(virtmachine);
> >           }
> > +    } else if (g_str_equal(arch, "loongarch64")) {
> > +        const char *virtmachine[] = { "virt", NULL };
> > +        add_cdrom_param_tests(virtmachine);
> >       } else {
> >           const char *nonemachine[] = { "none", NULL };
> >           add_cdrom_param_tests(nonemachine);
>
> Anyway, using the virt machine is certainly better than the "none" 
> machine, so:
> Acked-by: Thomas Huth <thuth@redhat.com>