Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()

From:	Cédric Le Goater
Subject:	Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()
Date:	Mon, 15 Apr 2024 16:01:59 +0200
User-agent:	Mozilla Thunderbird

On 4/12/24 17:25, Alex Williamson wrote:

On Wed, 10 Apr 2024 18:06:03 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience. Use g_strdup_printf()
instead.

Isn't this code only compiled for Linux hosts?


It is not.

Maybe still a valid change, but the rationale seems irrelevant.


I agree the commit log should be rephrased.

There is also a v2 doing a different change :

  20240411101550.99392-1-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20240411101550.99392-1-philmd@linaro.org/

This is a bit confusing.

Thanks,

C.

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/12] misc: Remove sprintf() due to macOS deprecation, Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf(), Philippe Mathieu-Daudé, 2024/04/10
  - Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf(), Marc-André Lureau, 2024/04/11
  - Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf(), Gerd Hoffmann, 2024/04/11
    - Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf(), Philippe Mathieu-Daudé, 2024/04/11
    - Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf(), Gerd Hoffmann, 2024/04/11
- [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf(), Philippe Mathieu-Daudé, 2024/04/10
  - Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf(), Alex Williamson, 2024/04/12
    - Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf(), Cédric Le Goater <=
- [PATCH 03/12] hw/ppc/spapr: Replace sprintf() by g_strdup_printf(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 04/12] hw/mips/malta: Replace sprintf() by g_string_append_printf(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 05/12] system/qtest: Replace sprintf() by g_string_append_printf(), Philippe Mathieu-Daudé, 2024/04/10
  - Re: [PATCH 05/12] system/qtest: Replace sprintf() by g_string_append_printf(), Thomas Huth, 2024/04/11
- [PATCH 06/12] util/hexdump: Rename @offset argument in qemu_hexdump_line(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 07/12] util/hexdump: Have qemu_hexdump_line() return heap allocated buffer, Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 08/12] util/hexdump: Replace sprintf() by g_string_append_printf(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 10/12] hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 09/12] hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf(), Philippe Mathieu-Daudé, 2024/04/10
- [PATCH 11/12] hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf(), Philippe Mathieu-Daudé, 2024/04/10

Prev by Date: Re: [PATCH v2 11/15] hw/southbridge/ich9: Add a AHCI function
Next by Date: MAINTAINERS tweak [was: [PATCH for-9.1 0/9] Switch to glib URI parsing code]
Previous by thread: Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()
Next by thread: [PATCH 03/12] hw/ppc/spapr: Replace sprintf() by g_strdup_printf()
Index(es):
- Date
- Thread