qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()


From: Cédric Le Goater
Subject: Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()
Date: Mon, 15 Apr 2024 16:01:59 +0200
User-agent: Mozilla Thunderbird

On 4/12/24 17:25, Alex Williamson wrote:
On Wed, 10 Apr 2024 18:06:03 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience. Use g_strdup_printf()
instead.

Isn't this code only compiled for Linux hosts?

It is not.

Maybe still a valid change, but the rationale seems irrelevant.

I agree the commit log should be rephrased.

There is also a v2 doing a different change :

  20240411101550.99392-1-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20240411101550.99392-1-philmd@linaro.org/

This is a bit confusing.

Thanks,

C.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]