qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] dc864d: osdep: add getloadavg


From: Philippe Mathieu-Daudé
Subject: [Qemu-commits] [qemu/qemu] dc864d: osdep: add getloadavg
Date: Mon, 04 Dec 2023 06:45:42 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: dc864d3a3777424187280e50c9bfb84dced54f12
      
https://github.com/qemu/qemu/commit/dc864d3a3777424187280e50c9bfb84dced54f12
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M include/qemu/osdep.h
    M meson.build

  Log Message:
  -----------
  osdep: add getloadavg

getloadavg is supported on Linux, BSDs, Solaris.

Following man page:
RETURN VALUE
       If the load average was unobtainable, -1 is returned; otherwise,
       the number of samples actually retrieved is returned.

accordingly, make stub for systems which don't support this function return -1
for consistency.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: cadfc7293977ecadc2d6c48d7cffc553ed2f85f1
      
https://github.com/qemu/qemu/commit/cadfc7293977ecadc2d6c48d7cffc553ed2f85f1
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M tests/qtest/netdev-socket.c

  Log Message:
  -----------
  netdev: set timeout depending on loadavg

netdev test keeps failing sometimes.
I don't think we should increase the timeout some more:
let's try something else instead, testing how busy the
system is.

Seems to work for me.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 5dcf6334ae1af158ec149794c3f35e459b98df5e
      
https://github.com/qemu/qemu/commit/5dcf6334ae1af158ec149794c3f35e459b98df5e
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M gdbstub/internals.h
    M gdbstub/system.c

  Log Message:
  -----------
  gdbstub: use a better signal when we halt for IO reasons

The gdb description GDB_SIGNAL_IO is "I/O possible" and by default gdb
will try and restart the guest, getting us nowhere. Report
GDB_SIGNAL_STOP instead which should at least halt the session at the
failure point.

Reviewed-by: Luis Machado <luis.machado@arm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231201093633.2551497-2-alex.bennee@linaro.org>


  Commit: 9b45cc9931866cedbe46d4372329074595267bfa
      
https://github.com/qemu/qemu/commit/9b45cc9931866cedbe46d4372329074595267bfa
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M docs/devel/testing.rst
    M tests/avocado/boot_linux.py
    M tests/avocado/boot_linux_console.py
    M tests/avocado/intel_iommu.py
    M tests/avocado/linux_initrd.py
    M tests/avocado/machine_aspeed.py
    M tests/avocado/machine_mips_malta.py
    M tests/avocado/machine_rx_gdbsim.py
    M tests/avocado/machine_s390_ccw_virtio.py
    M tests/avocado/replay_kernel.py
    M tests/avocado/reverse_debugging.py
    M tests/avocado/smmu.py
    M tests/avocado/tuxrun_baselines.py

  Log Message:
  -----------
  docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS

It doesn't make sense to have two classes of flaky tests. While it may
take the constrained environment of CI to trigger failures easily it
doesn't mean they don't occasionally happen on developer machines. As
CI is the gating factor to passing there is no point developers
running the tests locally anyway unless they are trying to fix things.

While we are at it update the language in the docs to discourage the
QEMU_TEST_FLAKY_TESTS becoming a permanent solution.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231201093633.2551497-3-alex.bennee@linaro.org>


  Commit: bc1d54ee51367955b50786323ee5a6bd8c0f0034
      
https://github.com/qemu/qemu/commit/bc1d54ee51367955b50786323ee5a6bd8c0f0034
  Author: Het Gala <het.gala@nutanix.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Plug memory leak with migration URIs

migrate_uri_parse() allocates memory to 'channel' if the user
opts for old syntax - uri, which is leaked because there is no
code for freeing 'channel'.
So, free channel to avoid memory leak in case where 'channels'
is empty and uri parsing is required.

Fixes: 5994024f ("migration: Implement MigrateChannelList to qmp migration 
flow")
Signed-off-by: Het Gala <het.gala@nutanix.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Tested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Link: https://lore.kernel.org/r/20231129204301.131228-1-het.gala@nutanix.com
Signed-off-by: Peter Xu <peterx@redhat.com>


  Commit: 970c6fc250b3cdc59f24833a9effd80b9a2f450c
      
https://github.com/qemu/qemu/commit/970c6fc250b3cdc59f24833a9effd80b9a2f450c
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M tests/avocado/machine_aarch64_sbsaref.py

  Log Message:
  -----------
  tests/avocado: tag sbsa tests as tcg only

As firmware runs at a higher privilege level than the hypervisor we
can only run these tests under TCG emulation.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231201093633.2551497-6-alex.bennee@linaro.org>


  Commit: aeb5f8f248e6b89732f5745f505742295adf7b66
      
https://github.com/qemu/qemu/commit/aeb5f8f248e6b89732f5745f505742295adf7b66
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml

  Log Message:
  -----------
  gitlab: build the correct microblaze target

We inadvertently built the LE target for BE tests.

Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231201093633.2551497-7-alex.bennee@linaro.org>


  Commit: 5d25fcb702406286a17806dd53d10eec1d2cc34f
      
https://github.com/qemu/qemu/commit/5d25fcb702406286a17806dd53d10eec1d2cc34f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M docs/devel/testing.rst
    M tests/avocado/boot_linux.py
    M tests/avocado/boot_linux_console.py
    M tests/avocado/intel_iommu.py
    M tests/avocado/linux_initrd.py
    M tests/avocado/machine_aspeed.py
    M tests/avocado/machine_mips_malta.py
    M tests/avocado/machine_rx_gdbsim.py
    M tests/avocado/machine_s390_ccw_virtio.py
    M tests/avocado/replay_kernel.py
    M tests/avocado/reverse_debugging.py
    M tests/avocado/smmu.py
    M tests/avocado/tuxrun_baselines.py

  Log Message:
  -----------
  gitlab: add optional job to run flaky avocado tests

One problem with flaky tests is they often only fail under CI
conditions which makes it hard to debug. We add an optional allow_fail
job so developers can trigger the only the flaky tests in the CI
environment if they are debugging.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231201093633.2551497-8-alex.bennee@linaro.org>


  Commit: de35244e99ff1c45a7b07f4024b8a70843d0f79c
      
https://github.com/qemu/qemu/commit/de35244e99ff1c45a7b07f4024b8a70843d0f79c
  Author: Ani Sinha <anisinha@redhat.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  tests/acpi/bios-tables-test: do not write new blobs unless there are changes

When dumping table blobs using rebuild-expected-aml.sh, table blobs from all
test variants are dumped regardless of whether there are any actual changes to
the tables or not. This creates lot of new files for various test variants that
are not part of the git repository. This is because we do not check in all table
blobs for all test variants into the repository. Only those blobs for those
variants that are different from the generic test-variant agnostic blob are
checked in.

This change makes the test smarter by checking if at all there are any changes
in the tables from the checked-in gold master blobs and take actions
accordingly.

When there are no changes:
 - No new table blobs would be written.
 - Existing table blobs will be refreshed (git diff will show no changes).
When there are changes:
 - New table blob files will be dumped.
 - Existing table blobs will be refreshed (git diff will show that the files
   changed, asl diff will show the actual changes).
When new tables are introduced:
 - Zero byte empty file blobs for new tables as instructed in the header of
   bios-tables-test.c will be regenerated to actual table blobs.

This would make analyzing changes to tables less confusing and there would
be no need to clean useless untracked files when there are no table changes.

CC: peter.maydell@linaro.org
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20231107044952.5461-1-anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>


  Commit: c44f4263b2fcd5847a50e57157a716ebe8d69d8c
      
https://github.com/qemu/qemu/commit/c44f4263b2fcd5847a50e57157a716ebe8d69d8c
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/audio/virtio-snd-pci.c

  Log Message:
  -----------
  hw/audio/virtio-snd-pci: fix the PCI class code

The virtio sound device is currently an unclassified PCI device.

~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Unclassified device [00ff]:
 Red Hat, Inc. Device [1af4:1059] (rev 01)
        Subsystem: Red Hat, Inc. Device [1af4:1100]

Set the correct PCI class code to change the device to a
multimedia audio controller.

~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Multimedia audio controller [0401]:
 Red Hat, Inc. Device [1af4:1059] (rev 01)
        Subsystem: Red Hat, Inc. Device [1af4:1100]

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20231107185034.6434-1-vr_qemu@t-online.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 74e8593e7e51d6b11ae9c56a3f4e7bb714bac4ec
      
https://github.com/qemu/qemu/commit/74e8593e7e51d6b11ae9c56a3f4e7bb714bac4ec
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/audio/hda-codec.c

  Log Message:
  -----------
  hw/audio/hda-codec: fix multiplication overflow

After a relatively short time, there is an multiplication overflow
when multiplying (now - buft_start) with hda_bytes_per_second().
While the uptime now - buft_start only overflows after 2**63 ns
= 292.27 years, this happens hda_bytes_per_second() times faster
with the multiplication. At 44100 samples/s * 2 channels
* 2 bytes/channel = 176400 bytes/s that is 14.52 hours. After the
multiplication overflow the affected audio stream stalls.

Replace the multiplication and following division with muldiv64()
to prevent a multiplication overflow.

Fixes: 280c1e1cdb ("audio/hda: create millisecond timers that handle IO")
Reported-by: M_O_Bz <m_o_bz@163.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20231105172552.8405-1-vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: e60bdfb78e41b0cee8beb21bc9c2bb2749f4ef6b
      
https://github.com/qemu/qemu/commit/e60bdfb78e41b0cee8beb21bc9c2bb2749f4ef6b
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/audio/hda-codec.c

  Log Message:
  -----------
  hw/audio/hda-codec: reenable the audio mixer

Commit b7639b7dd0 ("hw/audio: Simplify hda audio init") inverted
the sense of hda codec property mixer during initialization.
Change the code so that mixer=on enables the hda mixer emulation
and mixer=off disables the hda mixer emulation.

With this change audio playback and recording streams don't start
muted by default.

Fixes: b7639b7dd0 ("hw/audio: Simplify hda audio init")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20231105172552.8405-2-vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 691d3d8bbde16abd002a2590fa422b079d0c8468
      
https://github.com/qemu/qemu/commit/691d3d8bbde16abd002a2590fa422b079d0c8468
  Author: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/audio/virtio-snd.c

  Log Message:
  -----------
  virtio-snd: check AUD_register_card return value

AUD_register_card might fail. Even though errp was passed as an
argument, the call's return value was not checked for failure.

Fixes: Coverity CID 1523899
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <20231109162034.2108018-1-manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: f7856181849939ecb096dd1d0068b674fe2c69ff
      
https://github.com/qemu/qemu/commit/f7856181849939ecb096dd1d0068b674fe2c69ff
  Author: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/audio/virtio-snd.c

  Log Message:
  -----------
  virtio-sound: add realize() error cleanup path

QEMU crashes on exit when a virtio-sound device has failed to
realise. Its vmstate field was not cleaned up properly with
qemu_del_vm_change_state_handler().

This patch changes the realize() order as

1. Validate the given configuration values (no resources allocated
   by us either on success or failure)
2. Try AUD_register_card() and return on failure (no resources allocated
   by us on failure)
3. Initialize vmstate, virtio device, heap allocations and stream
   parameters at once.
   If error occurs, goto error_cleanup label which calls
   virtio_snd_unrealize(). This cleans up all resources made in steps
   1-3.

Reported-by: Volker Rümelin <vr_qemu@t-online.de>
Fixes: 2880e676c000 ("Add virtio-sound device stub")
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <20231116072046.4002957-1-manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 714a1415d7a69174e1640fcdd6eaae180fe438aa
      
https://github.com/qemu/qemu/commit/714a1415d7a69174e1640fcdd6eaae180fe438aa
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/pci/pcie_sriov.c

  Log Message:
  -----------
  pcie_sriov: Remove g_new assertion

g_new() aborts if the allocation fails so it returns NULL only if the
requested allocation size is zero. register_vfs() makes such an
allocation if NumVFs is zero so it should not assert that g_new()
returns a non-NULL value.

Fixes: 7c0fa8dff8 ("pcie: Add support for Single Root I/O Virtualization 
(SR/IOV)")
Buglink: https://issues.redhat.com/browse/RHEL-17209
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20231123075630.12057-1-akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Yanghang Liu<yanghliu@redhat.com>
Reviewed-by: Cédric Le Goater &lt;<a href="mailto:clg@redhat.com"; 
target="_blank">clg@redhat.com</a>&gt;<br>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 20bc50137f3add52eb4788b420d717de27fed14b
      
https://github.com/qemu/qemu/commit/20bc50137f3add52eb4788b420d717de27fed14b
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/acpi/erst.c

  Log Message:
  -----------
  hw/acpi/erst: Do not ignore Error* in realize handler

erst_realizefn() passes @errp to functions without checking for
failure.  If it runs into another failure, it trips error_setv()'s
assertion.

Use the ERRP_GUARD() macro and check *errp, as suggested in commit
ae7c80a7bd ("error: New macro ERRP_GUARD()").

Cc: qemu-stable@nongnu.org
Fixes: f7e26ffa59 ("ACPI ERST: support for ACPI ERST feature")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231120130017.81286-1-philmd@linaro.org>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c04cfb4596ad5032a9869a8f77fe9114ca8af9e0
      
https://github.com/qemu/qemu/commit/c04cfb4596ad5032a9869a8f77fe9114ca8af9e0
  Author: Daniel Hoffman <dhoff749@gmail.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/i386/x86.c

  Log Message:
  -----------
  hw/i386: fix short-circuit logic with non-optimizing builds

`kvm_enabled()` is compiled down to `0` and short-circuit logic is
used to remove references to undefined symbols at the compile stage.
Some build configurations with some compilers don't attempt to
simplify this logic down in some cases (the pattern appears to be
that the literal false must be the first term) and this was causing
some builds to emit references to undefined symbols.

An example of such a configuration is clang 16.0.6 with the following
configure: ./configure --enable-debug --without-default-features
--target-list=x86_64-softmmu --enable-tcg-interpreter

Signed-off-by: Daniel Hoffman <dhoff749@gmail.com>
Message-Id: <20231119203116.3027230-1-dhoff749@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c8559fcb1559b472e7ec79b990f5206249b2ba69
      
https://github.com/qemu/qemu/commit/c8559fcb1559b472e7ec79b990f5206249b2ba69
  Author: Eric Auger <eric.auger@redhat.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/virtio/virtio-iommu.c

  Log Message:
  -----------
  virtio-iommu: Remove useless !sdev check in virtio_iommu_probe()

The code already checks iommu_mr is not NULL so there is no
need to check container_of() is not NULL. Remove the check.

Fixes: CID 1523901
Fixes: 09b4c3d6a2 ("virtio-iommu: Record whether a probe request has
been issued")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Coverity (CID 1523901)
Message-Id: <20231109170715.259520-1-eric.auger@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 2d37fe9e5e61b04bddbed00dbb7436e61a01c115
      
https://github.com/qemu/qemu/commit/2d37fe9e5e61b04bddbed00dbb7436e61a01c115
  Author: Robert Hoo <robert.hoo.linux@gmail.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/pci/msix.c

  Log Message:
  -----------
  msix: unset PCIDevice::msix_vector_poll_notifier in rollback

In the rollback in msix_set_vector_notifiers(), original patch forgot to
undo msix_vector_poll_notifier pointer.

Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll")
Signed-off-by: Robert Hoo <robert.hoo.linux@gmail.com>
Message-Id: <20231113081349.1307-1-robert.hoo.linux@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 298d4f892e745cfb8a33b5ed2feaaab271f6e50c
      
https://github.com/qemu/qemu/commit/298d4f892e745cfb8a33b5ed2feaaab271f6e50c
  Author: Li Feng <fengli@smartx.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/block/vhost-user-blk.c
    M hw/scsi/vhost-user-scsi.c
    M hw/virtio/vhost-user-gpio.c

  Log Message:
  -----------
  vhost-user: fix the reconnect error

If the error occurs in vhost_dev_init, the value of s->connected is set to true
in advance, and there is no chance to enter this function execution again
in the future.

Signed-off-by: Li Feng <fengli@smartx.com>
Message-Id: <20231123055431.217792-2-fengli@smartx.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 95e1019a4a9b4b6e2caeb3fd392525e522a747db
      
https://github.com/qemu/qemu/commit/95e1019a4a9b4b6e2caeb3fd392525e522a747db
  Author: Li Feng <fengli@smartx.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M hw/scsi/vhost-user-scsi.c
    M hw/virtio/virtio.c

  Log Message:
  -----------
  vhost-user-scsi: free the inflight area when reset

Keep it the same to vhost-user-blk.
At the same time, fix the vhost_reset_device.

Signed-off-by: Li Feng <fengli@smartx.com>
Message-Id: <20231123055431.217792-3-fengli@smartx.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 53a939f1bf8e4a3e38f9449fac44f572676966ad
      
https://github.com/qemu/qemu/commit/53a939f1bf8e4a3e38f9449fac44f572676966ad
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M ui/gtk-egl.c

  Log Message:
  -----------
  ui/gtk-egl: move function calls back to regular code path

Commit 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing
scanout") introduced a regression when QEMU is running with a
virtio-gpu-gl-device on a host under X11. After the guest has
initialized the virtio-gpu-gl-device, the guest screen only
shows "Display output is not active.".

Commit 6f189a08c1 moved all function calls in
gd_egl_scanout_texture() to a code path which is only called
once after gd_egl_init() succeeds in gd_egl_scanout_texture().
Move all function calls in gd_egl_scanout_texture() back to
the regular code path so they get always called if one of the
gd_egl_init() calls was successful.

Fixes: 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing scanout")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231111104020.26183-1-vr_qemu@t-online.de>


  Commit: ebfbf394671163c14e2b24d98f3927a3151d1aff
      
https://github.com/qemu/qemu/commit/ebfbf394671163c14e2b24d98f3927a3151d1aff
  Author: Fiona Ebner <f.ebner@proxmox.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M ui/vnc-clipboard.c

  Log Message:
  -----------
  ui/vnc-clipboard: fix inflate_buffer

Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in
inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still
required, because it can happen that stream.avail_in becomes zero
before coming across a return value of Z_STREAM_END in the loop.

This fixes the host->guest direction of the clipboard with noVNC and
TigerVNC as clients.

Fixes: d921fea338 ("ui/vnc-clipboard: fix infinite loop in inflate_buffer 
(CVE-2023-3255)")
Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231122125826.228189-1-f.ebner@proxmox.com>


  Commit: 551ef0fa05c11abd62f4607ee3cddbcb7dea6b66
      
https://github.com/qemu/qemu/commit/551ef0fa05c11abd62f4607ee3cddbcb7dea6b66
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M hw/audio/virtio-snd.c

  Log Message:
  -----------
  hw/audio/virtio-sound: mark the device as unmigratable

The virtio-sound device is currently not migratable. QEMU crashes
on the source machine at some point during the migration with a
segmentation fault.

Even with this bug fixed, the virtio-sound device doesn't migrate
the state of the audio streams. For example, running streams leave
the device on the destination machine in a broken condition.

Mark the device as unmigratable until these issues have been fixed.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231204072837.6058-1-vr_qemu@t-online.de>


  Commit: 019f8c19df054fe14f18495bb95571c10cc0bf69
      
https://github.com/qemu/qemu/commit/019f8c19df054fe14f18495bb95571c10cc0bf69
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  Merge tag 'migration-20231201-pull-request' of 
https://github.com/xzpeter/qemu into staging

Migration patches for rc3:

- One more memleak regression fix from Het

# -----BEGIN PGP SIGNATURE-----
#
# iIgEABYKADAWIQS5GE3CDMRX2s990ak7X8zN86vXBgUCZWoLbRIccGV0ZXJ4QHJl
# ZGhhdC5jb20ACgkQO1/MzfOr1wahYwD+OsD7CaZYjkl9KSooRfblEenD6SdfhAdC
# oZc07f2UxocA/0s1keDBZUUcZOiGYPDFV5his4Jw4F+RRD1YIpVWZg4J
# =T0/r
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 01 Dec 2023 11:35:57 EST
# gpg:                using EDDSA key B9184DC20CC457DACF7DD1A93B5FCCCDF3ABD706
# gpg:                issuer "peterx@redhat.com"
# gpg: Good signature from "Peter Xu <xzpeter@gmail.com>" [full]
# gpg:                 aka "Peter Xu <peterx@redhat.com>" [full]
# Primary key fingerprint: B918 4DC2 0CC4 57DA CF7D  D1A9 3B5F CCCD F3AB D706

* tag 'migration-20231201-pull-request' of https://github.com/xzpeter/qemu:
  migration: Plug memory leak with migration URIs

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 173e8280643ad3b7221b12a8deafce826f5e7efb
      
https://github.com/qemu/qemu/commit/173e8280643ad3b7221b12a8deafce826f5e7efb
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M hw/acpi/erst.c
    M hw/audio/hda-codec.c
    M hw/audio/virtio-snd-pci.c
    M hw/audio/virtio-snd.c
    M hw/block/vhost-user-blk.c
    M hw/i386/x86.c
    M hw/pci/msix.c
    M hw/pci/pcie_sriov.c
    M hw/scsi/vhost-user-scsi.c
    M hw/virtio/vhost-user-gpio.c
    M hw/virtio/virtio-iommu.c
    M hw/virtio/virtio.c
    M include/qemu/osdep.h
    M meson.build
    M tests/qtest/bios-tables-test.c
    M tests/qtest/netdev-socket.c

  Log Message:
  -----------
  Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu 
into staging

virtio,pc,pci: features, cleanups, fixes

misc fixes, cleanups

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEXQn9CHHI+FuUyooNKB8NuNKNVGkFAmVrmhwPHG1zdEByZWRo
# YXQuY29tAAoJECgfDbjSjVRp/XsH/05hHtQqO+EnKSAW5SEwZnlLfzDcajVVPIkT
# h6Yf6ahHNf4hG1qqa2CICqJtDAOQYamO128QjZdQxsnYejwBmZ/oG//neWh6qLPV
# Hp4AaKV2MjKRQZPNblnrGUirxkSWSTqIONXp4FsVVpKOKW9IX5f9tH6nyFAqXWX7
# KzNY/3KD1CVSwAV1+hY2c6OzWVdTSJykPRocfB0jTYY1RygI0t57Hiq7v8AliGAx
# 7ktSJFD9MBr+4Un7CQZWp24eyrL77j8U+YQRlPVYupkmQyuXHPdBr4RruHcGupIy
# GeIvbkX1mTCEfOd/HFQ1X41hpf8AEyZjjq2SOEBncIRWY6EhSio=
# =opjy
# -----END PGP SIGNATURE-----
# gpg: Signature made Sat 02 Dec 2023 15:57:00 EST
# gpg:                using RSA key 5D09FD0871C8F85B94CA8A0D281F0DB8D28D5469
# gpg:                issuer "mst@redhat.com"
# gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>" [full]
# gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu:
  vhost-user-scsi: free the inflight area when reset
  vhost-user: fix the reconnect error
  msix: unset PCIDevice::msix_vector_poll_notifier in rollback
  virtio-iommu: Remove useless !sdev check in virtio_iommu_probe()
  hw/i386: fix short-circuit logic with non-optimizing builds
  hw/acpi/erst: Do not ignore Error* in realize handler
  pcie_sriov: Remove g_new assertion
  virtio-sound: add realize() error cleanup path
  virtio-snd: check AUD_register_card return value
  hw/audio/hda-codec: reenable the audio mixer
  hw/audio/hda-codec: fix multiplication overflow
  hw/audio/virtio-snd-pci: fix the PCI class code
  tests/acpi/bios-tables-test: do not write new blobs unless there are changes
  netdev: set timeout depending on loadavg
  osdep: add getloadavg

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 17dacf7ac9e2f076c15f32a290203f8f571a8800
      
https://github.com/qemu/qemu/commit/17dacf7ac9e2f076c15f32a290203f8f571a8800
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M docs/devel/testing.rst
    M gdbstub/internals.h
    M gdbstub/system.c
    M tests/avocado/boot_linux.py
    M tests/avocado/boot_linux_console.py
    M tests/avocado/intel_iommu.py
    M tests/avocado/linux_initrd.py
    M tests/avocado/machine_aarch64_sbsaref.py
    M tests/avocado/machine_aspeed.py
    M tests/avocado/machine_mips_malta.py
    M tests/avocado/machine_rx_gdbsim.py
    M tests/avocado/machine_s390_ccw_virtio.py
    M tests/avocado/replay_kernel.py
    M tests/avocado/reverse_debugging.py
    M tests/avocado/smmu.py
    M tests/avocado/tuxrun_baselines.py

  Log Message:
  -----------
  Merge tag 'pull-more-8.2-fixes-011223-2' of https://gitlab.com/stsquad/qemu 
into staging

Flaky avocado tests, gdbstub and gitlab tweaks

  - gdbstub, properly halt when QEMU is having IO issues
  - convert skipIf(GITLAB_CI) to skipUnless(QEMU_TEST_FLAKY_TESTS)
  - tag sbsa-ref tests as TCG only
  - build the correct microblaze for avocado-system-ubuntu
  - add optional flaky tests job to CI

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmVqHFgACgkQ+9DbCVqe
# KkQHLwgAjP2iL5LSa3FaMUoESJQqRB0rpoJ80gtEtmvmgRF0fHsRfHtDdMN9h2Ed
# YilCDhMKLyr2ZoK4atyuc5SR6vCXI5RAvfTddex0xSxlvBX5Z5+1FMC6yA8SDJM7
# ezEXACEKHiGv+l8gvOZOf9ZYEgh8DMJYFMbrtxuxKWw/kAjZ3R3X/ChCL94ZCPRe
# 486wqPIQfp5EPs2ddsW4DYFTjLpK5ImX+u/5kdaEGXwcg8UoLmQ9BVIrN/hYJ6u5
# t/mAp1qVIQwSOSUBnerQ4ZkVQfCgLtEtiDtt8EZjUbQD3DcLjfHFjTwVlpqcC1zs
# wHXYpLbD5jkthqav5E0DObCF9gIZdA==
# =qtvU
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 01 Dec 2023 12:48:08 EST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* tag 'pull-more-8.2-fixes-011223-2' of https://gitlab.com/stsquad/qemu:
  gitlab: add optional job to run flaky avocado tests
  gitlab: build the correct microblaze target
  tests/avocado: tag sbsa tests as tcg only
  docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
  gdbstub: use a better signal when we halt for IO reasons

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 8e51bae8abe3d3433bc7c2ce42e3328923523ba8
      
https://github.com/qemu/qemu/commit/8e51bae8abe3d3433bc7c2ce42e3328923523ba8
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M hw/audio/virtio-snd.c
    M ui/gtk-egl.c
    M ui/vnc-clipboard.c

  Log Message:
  -----------
  Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into 
staging

ui/audio fixes for 8.2

# -----BEGIN PGP SIGNATURE-----
#
# iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmVtiO0cHG1hcmNhbmRy
# ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5UDeEACvbixo8MuxOpBf9DK2
# JTCQeHYeVW7QtwDh9xUUnbcM77+lWgkr9OeCJ7FKxF1J7UHkQ7jIzISs/P0zuCw0
# JRkoOcfOnxV/Pn8XAq79F6Yq55EUdCdvsj0XgsVx+K096VHvjlK3fzNwNebJrkos
# NpwQnnqI37TYBUFSivjKkEkPf1Kp4R4abeNs3eEzsIMUzEmEZQwwi5zZAMxxZ41o
# fyItvdaEEDJxzupS6e0x4O4B5KkTo9RFwsJgstOAbkCxuJk67grV9dm3S3wFiUR3
# iFR2P/EyzctT9QOkU7oEIi87CiociKaYWgw/tDU4lFjXwbkt0a59b783Rha1RlN8
# ICFQ3B0NX+CNlc5PPsF1yp3+DNJRKz8Rap4PmU5IIVXTlPHm+YrWRw6vklw5kq7y
# nAvdcfIJ+UQGVCgqQiLkuZslz4ATFOypnUvSL+eds1jHMS6UQcGd3zD1QCEPhDSP
# jhFirqDQYWU/18ZU3b6VuDe5Ko3erd4V7hDikeQnjLjYfBFX1/Mts+6GmaGdfbqk
# JLOHYa7CUP7akTB7fQF1/4B6cSf3hOsXYlmDHQPZgi1OYEy/BdPuwM5pN4jAikwO
# b2z6TrXS3hQK61bUtU+XnhOOW98+gfz77UwluXDl22KHGV+c/SadyMFJWm8VYX4k
# DuNTQ78vApqCuAhjFcKSXPSt7A==
# =fpz/
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 04 Dec 2023 03:08:13 EST
# gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
# gpg:                issuer "marcandre.lureau@redhat.com"
# gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" 
[full]
# gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" 
[full]
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu:
  hw/audio/virtio-sound: mark the device as unmigratable
  ui/vnc-clipboard: fix inflate_buffer
  ui/gtk-egl: move function calls back to regular code path

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 1664d74c50739401c8b40e8b514d12b5fc250067
      
https://github.com/qemu/qemu/commit/1664d74c50739401c8b40e8b514d12b5fc250067
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M tests/avocado/machine_mips_malta.py

  Log Message:
  -----------
  tests/avocado: Update yamon-bin-02.22.zip URL

http://www.imgtec.com/tools/mips-tools/downloads/ redirects
to https://mips.com/downloads/yamon-version-02-22/ then points
to an invalid path to a s3 bucket. Use the correct path. The
site will eventually be fixed.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20231201205630.10837-1-philmd@linaro.org>


Compare: https://github.com/qemu/qemu/compare/29b5d70cb705...1664d74c5073



reply via email to

[Prev in Thread] Current Thread [Next in Thread]