[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documenta
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documentation (v2) |
Date: |
Thu, 10 Nov 2011 10:41:40 -0200 |
qemu_fclose() and QEMUFile->close will return -errno on error, and any
positive value on success.
We need the positive non-zero success values because
migration-exec.c:exec_close() relies on non-zero return values to get
the process exit code.
Changes v1 -> v2:
- Cosmetic spelling change on comment text
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/hw.h | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index ed20f5a..efa04d1 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -27,7 +27,13 @@ typedef int (QEMUFilePutBufferFunc)(void *opaque, const
uint8_t *buf,
typedef int (QEMUFileGetBufferFunc)(void *opaque, uint8_t *buf,
int64_t pos, int size);
-/* Close a file and return an error code */
+/* Close a file
+ *
+ * Return negative error number on error, 0 or positive value on success.
+ *
+ * The meaning of return value on success depends on the specific back-end
being
+ * used.
+ */
typedef int (QEMUFileCloseFunc)(void *opaque);
/* Called to determine if the file has exceeded it's bandwidth allocation. The
--
1.7.3.2
- [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documentation (v2),
Eduardo Habkost <=
- [Qemu-devel] [PATCH 04/10] migrate_fd_cleanup: accept any negative qemu_fclose() value as error, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 01/10] savevm: use qemu_file_set_error() instead of setting last_error directly, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 06/10] stdio_pclose: return -errno on error (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 05/10] qemu_fclose: return last_error if set (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 03/10] exec_close(): accept any negative value as qemu_fclose() error, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 07/10] stdio_fclose: return -errno on errors (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 10/10] unix_close(): check for close() errors too (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 08/10] exec_close(): return -errno on errors (v2), Eduardo Habkost, 2011/11/10