[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too (v2
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too (v2) |
Date: |
Thu, 10 Nov 2011 10:41:47 -0200 |
In case close() fails, we want to report the error back.
Changes v1 -> v2:
- Use braces on if statement to match coding style
Signed-off-by: Eduardo Habkost <address@hidden>
---
migration-tcp.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 5aa742c..cf6a9b8 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -40,12 +40,15 @@ static int socket_write(MigrationState *s, const void *
buf, size_t size)
static int tcp_close(MigrationState *s)
{
+ int r = 0;
DPRINTF("tcp_close\n");
if (s->fd != -1) {
- close(s->fd);
+ if (close(s->fd) < 0) {
+ r = -errno;
+ }
s->fd = -1;
}
- return 0;
+ return r;
}
static void tcp_wait_for_connect(void *opaque)
--
1.7.3.2
- [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documentation (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 04/10] migrate_fd_cleanup: accept any negative qemu_fclose() value as error, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 01/10] savevm: use qemu_file_set_error() instead of setting last_error directly, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too (v2),
Eduardo Habkost <=
- [Qemu-devel] [PATCH 06/10] stdio_pclose: return -errno on error (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 05/10] qemu_fclose: return last_error if set (v3), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 03/10] exec_close(): accept any negative value as qemu_fclose() error, Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 07/10] stdio_fclose: return -errno on errors (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 10/10] unix_close(): check for close() errors too (v2), Eduardo Habkost, 2011/11/10
- [Qemu-devel] [PATCH 08/10] exec_close(): return -errno on errors (v2), Eduardo Habkost, 2011/11/10