Re: [Qemu-devel] [PATCH 07/10] qtest: IRQ interception infrastructure (v2)

[Anthony Liguori]

On 02/25/2012 02:20 PM, Paolo Bonzini wrote:
> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
> > @@ -224,7 +223,9 @@ static void pc_init1(MemoryRegion *system_memory,
> >           gsi_state->i8259_irq[i] = i8259[i];
> >       }
> >       if (pci_enabled) {
> > -        ioapic_init(gsi_state);
> > +        dev = ioapic_init(gsi_state);
> > +        object_property_add_child(object_resolve_path("/i440fx/piix3", NULL),
> > +                                  "ioapic", OBJECT(dev), NULL);
> >       }
> >
> >       pc_register_ferr_irq(gsi[13]);
>
> Jan objected to putting this under /i440fx/piix3.

It's not technically part of the PIIX3 packaging, but the I/O APIC is attached 
to the PIIX3 and it's I/O requests propagate through the I/O APIC.  See section 
8.12 of the PIIX4 manual.

I think for our model, having it as a child property makes quite a lot of sense.

Regards,

Anthony Liguori

> Paolo