[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state |
Date: |
Fri, 4 May 2012 13:50:54 -0300 |
On Fri, 04 May 2012 18:39:06 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 0166ec2..4dbcb26 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -116,12 +116,14 @@
> > #
> > # @shutdown: guest is shut down (and -no-shutdown is in use)
> > #
> > +# @suspended: guest is suspended (ACPI S3)
> > +#
> > # @watchdog: the watchdog action is configured to pause and has been
> > triggered
> > ##
> > { 'enum': 'RunState',
> > 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> > 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> > - 'running', 'save-vm', 'shutdown', 'watchdog' ] }
> > + 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
> >
>
> This breaks QAPI ABI.
>
> Not really a breaker for this series, but it shows how we are not yet
> ready to keep a stable ABI (as opposed to API), and thus any
Having to add a new enum every time a new value is needed is going to be fun.
[Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order, Luiz Capitulino, 2012/05/04