[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow |
Date: |
Fri, 04 May 2012 18:51:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 |
Am 04.05.2012 18:29, schrieb Paolo Bonzini:
Il 04/05/2012 18:28, Stefan Weil ha scritto:
- !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { + if (cmd.xfer>
INT32_MAX) { + req = scsi_req_alloc(&reqops_invalid_field, d, tag,
lun, hba_private);
WARNING: line over 80 characters #54: FILE: hw/scsi-bus.c:533: + req
= scsi_req_alloc(&reqops_invalid_field, d, tag, lun, hba_private);
total: 0 errors, 1 warnings, 50 lines checked
0002-scsi-prevent-data-transfer-overflow.patch has style problems,
please review. If any of these errors are false positives report them
to the maintainer, see CHECKPATCH in MAINTAINERS.
It's a warning for a reason... Paolo
That's ok. It was just funny that a patch which prevents
data transfer overflow introduces a line overflow :-)
The tabs in patches 6 and 7 are more problematic.
Although they are not at the start of the line, tabs
should be completely avoided (that's my personal
understanding of QEMU's coding rules).
Existing code which violates that rule is no reason to
add more code with tabs. Exceptions should be possible
for code imported from other projects, maybe also
when existing code with tabs is extended.
But what is even more important than those tabs is
getting the fixes in qemu 1.1. I pulled them just
to see whether my scsi problem was fixed, and it's
git and checkpatch.pl which complains, not me :-)
Cheers,
Stefan
[Qemu-devel] [PATCH 04/14] scsi: fix WRITE SAME transfer length and direction, Paolo Bonzini, 2012/05/04
[Qemu-devel] [PATCH 05/14] scsi: Specify the xfer direction for UNMAP and ATA_PASSTHROUGH commands, Paolo Bonzini, 2012/05/04
[Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features, Paolo Bonzini, 2012/05/04
[Qemu-devel] [PATCH 07/14] scsi-disk: add dpofua property, Paolo Bonzini, 2012/05/04
[Qemu-devel] [PATCH 08/14] scsi: do not report bogus overruns for commands in the 0x00-0x1F range, Paolo Bonzini, 2012/05/04