[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage |
Date: |
Wed, 23 May 2012 19:40:51 +0000 |
On Wed, May 23, 2012 at 3:41 AM, Andreas Färber <address@hidden> wrote:
> Am 18.05.2012 11:49, schrieb TeLeMan:
>> This breakage was introduced by the commit "memory: make
>> phys_page_find() return an unadjusted".
>
> You seem to have found the origin of your problem. If you also mention
> the commit hash in your commit message then certain frontends (gitk,
> repo.or.cz) will display it as a handy hyperlink to that commit.
>
>>
>> Signed-off-by: TeLeMan <address@hidden>
>
> Signed-off-by is a legal statement of origin and must not be a pseudonym.
$ git log --author=.*eleman
commit c62f6d1d76aea587556c85b6b7b5c44167006264
Author: TeLeMan <address@hidden>
Date: Mon Jul 25 16:29:14 2011 +0800
monitor: fix build breakage with --disable-vnc
The breakage was introduced by the commit
13661089810d3e59931f3e80d7cb541b99af7071
Signed-off-by: TeLeMan <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
and several others.
>
> /-F
>
>> ---
>> exec.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/exec.c b/exec.c
>> index 0607c9b..ad99476 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -1475,7 +1475,8 @@ void tb_invalidate_phys_addr(target_phys_addr_t addr)
>>
>> static void breakpoint_invalidate(CPUArchState *env, target_ulong pc)
>> {
>> - tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc));
>> + tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc)
>> + | (pc & ~TARGET_PAGE_MASK));
>> }
>> #endif
>> #endif /* TARGET_HAS_ICE */
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, (continued)
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Andreas Färber, 2012/05/22
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Jan Kiszka, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Jan Kiszka, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Jan Kiszka, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Jan Kiszka, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Jan Kiszka, 2012/05/23
Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Andreas Färber, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Blue Swirl, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Anthony Liguori, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/23
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Andreas Färber, 2012/05/24
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Stefan Weil, 2012/05/24
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Anthony Liguori, 2012/05/24
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Stefan Weil, 2012/05/24
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, Anthony Liguori, 2012/05/24
- Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage, TeLeMan, 2012/05/24