|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage |
Date: | Thu, 24 May 2012 20:12:28 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 24.05.2012 15:35, schrieb Andreas Färber:
Am 24.05.2012 04:12, schrieb TeLeMan:I won't use my Chinese name because I think it's my privacy.That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's a certification of whom the code came from and who would be to blame if anything was wrong with that (think non-GPL-compatible code taken from somewhere else). Why should you be granted more privacy than us just because your name is Chinese? There's quite a few Chinese IBM guys around that don't seem to have any problem with this, and git would even handle UTF-8 characters quite well if desired[*]. Andreas [*] For example, commit e965fc380703110e967febf8d5b2ecd7db53b5d2 Author: 陳韋任 <address@hidden> Date: Mon Feb 6 14:02:55 2012 +0800 cpu-exec.c: Correct comment about this file and indentation cleanup Each target uses the #define macro (in target-xxx/cpu.h) to rename cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the i386 emulator main execution loop. This patch corrects the comment of this file and does indentation cleanup. Signed-off-by: Chen Wei-Ren (陳韋任) <address@hidden> Signed-off-by: Stefan Hajnoczi <address@hidden> This discussion looks strange for me. If someone contributes to QEMU not only with patches but also on qemu-devel and in other forms since a long time, I appreciate his/her contributions, no matter what his/her name is. Names are not absolute. There are cultural differences with regard to names and their meaning - just think of the way names change when someone gets married. There are a lot of good and acceptable reasons why someone chooses to use a nickname or a pseudonym. If we strictly enforce real names, some people would simply choose a pseudonym. Maybe others would stop contributing. Therefore I suggest a pragmatical approach: if someone contributes for the first time using a nickname, it is good practice to tell that person that a real name is wanted. I would not insist on a real name, because there is no way to verify it, but verify such patches more carefully. When people contribute using a nick name for a long time, that nick _is_ their name, and I know them by that name as I know Andreas, Anthony or Avi. Blue and TeLeMan are well known names. I did not review the patch, but if the code is ok, I suggest to apply it. Regards, Stefan W. |
[Prev in Thread] | Current Thread | [Next in Thread] |