[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "ra
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o" |
Date: |
Tue, 20 Aug 2013 09:51:33 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben:
> Il 16/08/2013 16:15, Laszlo Ersek ha scritto:
> > +static int raw_reopen_prepare(BDRVReopenState *reopen_state,
> > + BlockReopenQueue *queue, Error **errp)
> > {
> > - return bdrv_reopen_prepare(bs->file);
> > + BDRVReopenState tmp = *reopen_state;
> > +
> > + tmp.bs = tmp.bs->file;
> > + return bdrv_reopen_prepare(&tmp, queue, errp);
> > }
>
> This should just return zero, my fault.
Which is because bdrv_reopen_queue() already queues bs->file for reopen.
The simple return 0; implementation is shared by all other format drivers
that support reopening images.
Kevin
- [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw", Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 1/7] add skeleton for BSD licensed "raw" BlockDriver, Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 2/7] raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev(), Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 3/7] raw_bsd: add raw_create(), Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 4/7] raw_bsd: introduce "special members", Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 5/7] raw_bsd: add raw_create_options, Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o", Laszlo Ersek, 2013/08/16
- [Qemu-devel] [PATCH 6/7] raw_bsd: register bdrv_raw, Laszlo Ersek, 2013/08/16
- Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw", Anthony Liguori, 2013/08/16
- Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw", Kevin Wolf, 2013/08/20