[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "ra
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" |
Date: |
Tue, 20 Aug 2013 10:21:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben:
> Paolo asked me to write such a driver based on his textual specification
> alone. The first patch captures his email in full, the rest re-quotes
> parts that are being implemented.
>
> The tree compiles at each patch. The series passes "make check-block".
>
> "block/raw.c" is not removed because I wanted to keep it out of my
> series and out of my brain.
>
> Disclaimer: I couldn't care less if the raw block driver was public
> domain or AGPLv3+, as long as it qualifies as free software. I'm only
> trying to do what Paolo asked of me.
>
> Laszlo Ersek (7):
> add skeleton for BSD licensed "raw" BlockDriver
> raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev()
> raw_bsd: add raw_create()
> raw_bsd: introduce "special members"
> raw_bsd: add raw_create_options
> raw_bsd: register bdrv_raw
> switch raw block driver from "raw.o" to "raw_bsd.o"
>
> block/Makefile.objs | 2 +-
> block/raw_bsd.c | 186
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 187 insertions(+), 1 deletions(-)
> create mode 100644 block/raw_bsd.c
Reviewed if the individual added functions make sense, whether all
necessary function from struct BlockDriver are implemented, and which
fields from BlockDriverState need special handling (it's only bs->sg,
and we should probably get rid of that requirement)
Looks good in general, but please CC Stefan and me for v2 (like for all
block patches).
Kevin
- Re: [Qemu-devel] [PATCH 4/7] raw_bsd: introduce "special members", (continued)