Re: [Qemu-devel] [PATCH v4 06/21] target-arm: Provide syndrome information for MMU faults

[Peter Maydell]

On 17 March 2014 03:28, Peter Crosthwaite <address@hidden> wrote:
> On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell <address@hidden> wrote:
>> From: Rob Herring <address@hidden>

>> +    /* Set bit 26 for exceptions with no change in EL */
>> +    if (arm_current_pl(env)) {
>> +        syn |= 1 << ARM_EL_EC_SHIFT;
>> +    }
>> +
>
> Perhaps in internals.h:
>
> #define ARM_EL_EC_SAME_LEVEL (1 << ARM_EL_EC_SHIFT)
>
> Then this becomes:
>
> syn |= ARM_EL_EC_SAME_LEVEL
>
> Then in internals.h you can be more self documenting with:
>
> EC_BREAKPOINT_SAME_EL = EC_BREAKPOINT | ARM_EL_EC_SAME_LEVEL

Yeah, seems reasonable.

-- PMM