[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] target-tricore: Change SSOV/SUOV makro name
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] target-tricore: Change SSOV/SUOV makro name to SSOV32/SUOV32 |
Date: |
Fri, 12 Dec 2014 11:31:01 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/12/2014 09:31 AM, Bastian Koppelmann wrote:
> -#define SSOV(env, ret, arg, len) do { \
> - int64_t max_pos = INT##len ##_MAX; \
> - int64_t max_neg = INT##len ##_MIN; \
> +#define SSOV32(env, ret, arg) do { \
> + int64_t max_pos = INT32_MAX; \
> + int64_t max_neg = INT32_MIN; \
Now that you don't need token pasting, I think these would
be better as regular functions than macros.
r~
- [Qemu-devel] [PATCH 3/8] target-tricore: Add instructions of RR opcode format, that have 0xf as the first opcode, (continued)
- [Qemu-devel] [PATCH 3/8] target-tricore: Add instructions of RR opcode format, that have 0xf as the first opcode, Bastian Koppelmann, 2014/12/12
- [Qemu-devel] [PATCH 5/8] target-tricore: Add instructions of RR opcode format, that have 0x4b as the first opcode, Bastian Koppelmann, 2014/12/12
- [Qemu-devel] [PATCH 7/8] target-tricore: Fix MFCR/MTCR insn and B format offset., Bastian Koppelmann, 2014/12/12
- [Qemu-devel] [PATCH 8/8] target-tricore: Add instructions of RR1 opcode format, that have 0xb3 as first opcode, Bastian Koppelmann, 2014/12/12
- [Qemu-devel] [PATCH 1/8] target-tricore: Change SSOV/SUOV makro name to SSOV32/SUOV32, Bastian Koppelmann, 2014/12/12
- Re: [Qemu-devel] [PATCH 1/8] target-tricore: Change SSOV/SUOV makro name to SSOV32/SUOV32,
Richard Henderson <=
- [Qemu-devel] [PATCH 6/8] target-tricore: Add missing 1.6 insn of BOL opcode format, Bastian Koppelmann, 2014/12/12
- [Qemu-devel] [PATCH 2/8] target-tricore: Add instructions of RR opcode format, that have 0xb as the first opcode, Bastian Koppelmann, 2014/12/12