[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc'
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap |
Date: |
Thu, 2 Apr 2015 20:08:10 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Mar 21, 2015 at 02:25:42 -0400, Emilio G. Cota wrote:
> Note that this test
> if (b & ((1 << len) - 1))
> can be simplified to
> if (b & 1)
> , since we know that iff the first bit of a tb is set,
> all other bits from that tb are set too.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> translate-all.c | 39 +++++----------------------------------
> 1 file changed, 5 insertions(+), 34 deletions(-)
*ping*
http://patchwork.ozlabs.org/patch/452907/
Any takers? get_maintainer.pl doesn't suggest anybody to send this to.
This gets rid of an unnecessary (and hairy) function: bitmap_set().
I even took the time to double-check with a test program that
this function is indeed equivalent to bitmap_set().
Thanks,
Emilio
- Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap,
Emilio G. Cota <=