[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc'
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap |
Date: |
Fri, 03 Apr 2015 16:18:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/04/2015 02:08, Emilio G. Cota wrote:
> On Sat, Mar 21, 2015 at 02:25:42 -0400, Emilio G. Cota wrote:
>> Note that this test
>> if (b & ((1 << len) - 1))
>> can be simplified to
>> if (b & 1)
>> , since we know that iff the first bit of a tb is set,
>> all other bits from that tb are set too.
>>
>> Signed-off-by: Emilio G. Cota <address@hidden>
>> ---
>> translate-all.c | 39 +++++----------------------------------
>> 1 file changed, 5 insertions(+), 34 deletions(-)
>
> *ping*
> http://patchwork.ozlabs.org/patch/452907/
>
> Any takers? get_maintainer.pl doesn't suggest anybody to send this to.
>
> This gets rid of an unnecessary (and hairy) function: bitmap_set().
> I even took the time to double-check with a test program that
> this function is indeed equivalent to bitmap_set().
Nobody was looking because of the hard freeze, I guess. The patch looks
good.
Paolo