[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 11/36] qapi: Tighten checking of unions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 11/36] qapi: Tighten checking of unions |
Date: |
Tue, 28 Apr 2015 20:51:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/27/2015 12:32 PM, Eric Blake wrote:
> On 04/27/2015 12:15 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> Previous commits demonstrated that the generator had several
>>> flaws with less-than-perfect unions:
>
>>> +++ b/tests/qapi-schema/alternate-array.json
>>> @@ -1,4 +1,4 @@
>>> -# FIXME: we do not support array branches of anonymous unions yet
>>> +# we do not support array branches of anonymous unions yet
>>> # TODO: should we support this?
>>> { 'type': 'One',
>>> 'data': { 'name': 'str' } }
>>
>> FIXME added in PATCH 08, demoted to plain comment now. Any particular
>> reason for the churn?
>
> Poor rebasing skills on my part. I should have nuked the 'FIXME' out of
> commit 8, instead of churning here.
Actually, commit 8 was demonstrating that we didn't flag arrays as
invalid even though they don't work, and this commit fixes things to
start rejecting them. Meanwhile, the TODO reminds us that we may once
again want to accept them, but in a working configuration. At any rate,
minor wording tweaks should make it more obvious.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 02/36] qapi: Document type-safety considerations, (continued)
- [Qemu-devel] [PATCH v6 21/36] qapi: Allow true, false and null in schema json, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 17/36] qapi: Add some expr tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 19/36] qapi: Add tests of redefined expressions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 22/36] qapi: Unify type bypass and add tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 18/36] qapi: Better error messages for bad expressions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anonymous union, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 20/36] qapi: Better error messages for duplicated expressions, Eric Blake, 2015/04/05