[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 38/42] target-mips: fix memory leak
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 38/42] target-mips: fix memory leak |
Date: |
Thu, 30 Apr 2015 08:08:51 +0300 |
From: Gonglei <address@hidden>
Coveristy reports that variable prom_buf/params_buf going
out of scope leaks the storage it points to.
Cc: Aurelien Jarno <address@hidden>
Cc: Leon Alrae <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Leon Alrae <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/mips/mips_fulong2e.c | 1 +
hw/mips/mips_malta.c | 1 +
hw/mips/mips_r4k.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 4aae64a..dea941a 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -168,6 +168,7 @@ static int64_t load_kernel (CPUMIPSState *env)
rom_add_blob_fixed("prom", prom_buf, prom_size,
cpu_mips_kseg0_to_phys(NULL, ENVP_ADDR));
+ g_free(prom_buf);
return kernel_entry;
}
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index b0fa71a..482250d 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -861,6 +861,7 @@ static int64_t load_kernel (void)
rom_add_blob_fixed("prom", prom_buf, prom_size,
cpu_mips_kseg0_to_phys(NULL, ENVP_ADDR));
+ g_free(prom_buf);
return kernel_entry;
}
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 66e2a58..f4dcacd 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -139,6 +139,7 @@ static int64_t load_kernel(void)
rom_add_blob_fixed("params", params_buf, params_size,
(16 << 20) - 264);
+ g_free(params_buf);
return entry;
}
--
2.1.4
- [Qemu-devel] [PULL 12/42] hostmem: Fix mem-path property name in error report, (continued)
- [Qemu-devel] [PULL 12/42] hostmem: Fix mem-path property name in error report, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 02/42] tpm: Modify DPRINTF to enable -Wformat checking, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 05/42] ui/vnc : remove 'struct' of 'typedef struct', Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 03/42] bitops : fix coding style, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 27/42] microblaze: cpu: Remove unused CC_OP enum, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 20/42] configure: alphabetize tricore in target list, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 14/42] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags(), Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 30/42] microblaze: cpu: delete unused cpu_interrupts_enabled, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 07/42] hw/display : remove 'struct' from 'typedef QXL struct', Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 18/42] util: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 38/42] target-mips: fix memory leak,
Michael Tokarev <=
- [Qemu-devel] [PULL 13/42] qemu-options: trivial spelling fix (messsage), Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 19/42] arm: cpu.h: Remove unused typdefs, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 40/42] kvm: Silence warning from valgrind, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 09/42] range: remove useless inclusions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 01/42] tpm: Cast 64bit variables to int when used in DPRINTF, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 16/42] monitor: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 25/42] microblaze: mmu: Delete flip_um fn prototype, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 26/42] microblaze: cpu: Remote unused cpu_get_pc, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 42/42] microblaze: fix memory leak, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb(), Michael Tokarev, 2015/04/30