[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 40/42] kvm: Silence warning from valgrind
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 40/42] kvm: Silence warning from valgrind |
Date: |
Thu, 30 Apr 2015 08:08:53 +0300 |
From: Thomas Huth <address@hidden>
valgrind complains here about uninitialized bytes with the following message:
==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814== at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814== by 0x100735B7: kvm_vm_ioctl (kvm-all.c:1920)
==17814== by 0x10074583: kvm_set_ioeventfd_mmio (kvm-all.c:574)
Let's fix it by using a proper struct initializer in kvm_set_ioeventfd_mmio().
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
kvm-all.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 2a717e5..37cc2cf 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -552,13 +552,13 @@ static int kvm_set_ioeventfd_mmio(int fd, hwaddr addr,
uint32_t val,
bool assign, uint32_t size, bool datamatch)
{
int ret;
- struct kvm_ioeventfd iofd;
-
- iofd.datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) : 0;
- iofd.addr = addr;
- iofd.len = size;
- iofd.flags = 0;
- iofd.fd = fd;
+ struct kvm_ioeventfd iofd = {
+ .datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) : 0,
+ .addr = addr,
+ .len = size,
+ .flags = 0,
+ .fd = fd,
+ };
if (!kvm_enabled()) {
return -ENOSYS;
--
2.1.4
- [Qemu-devel] [PULL 03/42] bitops : fix coding style, (continued)
- [Qemu-devel] [PULL 03/42] bitops : fix coding style, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 27/42] microblaze: cpu: Remove unused CC_OP enum, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 20/42] configure: alphabetize tricore in target list, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 14/42] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags(), Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 30/42] microblaze: cpu: delete unused cpu_interrupts_enabled, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 07/42] hw/display : remove 'struct' from 'typedef QXL struct', Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 18/42] util: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 38/42] target-mips: fix memory leak, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 13/42] qemu-options: trivial spelling fix (messsage), Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 19/42] arm: cpu.h: Remove unused typdefs, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 40/42] kvm: Silence warning from valgrind,
Michael Tokarev <=
- [Qemu-devel] [PULL 09/42] range: remove useless inclusions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 01/42] tpm: Cast 64bit variables to int when used in DPRINTF, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 16/42] monitor: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 25/42] microblaze: mmu: Delete flip_um fn prototype, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 26/42] microblaze: cpu: Remote unused cpu_get_pc, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 42/42] microblaze: fix memory leak, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb(), Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 17/42] usb: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 35/42] linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it, Michael Tokarev, 2015/04/30
- [Qemu-devel] [PULL 31/42] cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus), Michael Tokarev, 2015/04/30