Re: [Qemu-devel] [PATCH 04/10] hw/mips/gt64xxx_pci: Fix 'spaces' coding style issues

[Aleksandar Markovic]

On Jun 25, 2019 12:29 AM, "Philippe Mathieu-Daudé" <address@hidden> wrote:
>
> Since we'll move this code around, fix its style first:
>
>   ERROR: space prohibited between function name and open parenthesis
>   ERROR: line over 90 characters
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---

Reviewed-by: Aleksandar Markovic <address@hidden>

>  hw/mips/gt64xxx_pci.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c
> index cfd497960c..0b9fb02475 100644
> --- a/hw/mips/gt64xxx_pci.c
> +++ b/hw/mips/gt64xxx_pci.c
> @@ -384,8 +384,8 @@ static const VMStateDescription vmstate_gt64120 = {
>      }
>  };
>
> -static void gt64120_writel (void *opaque, hwaddr addr,
> -                            uint64_t val, unsigned size)
> +static void gt64120_writel(void *opaque, hwaddr addr,
> +                           uint64_t val, unsigned size)
>  {
>      GT64120State *s = opaque;
>      PCIHostState *phb = PCI_HOST_BRIDGE(s);
> @@ -671,8 +671,8 @@ static void gt64120_writel (void *opaque, hwaddr addr,
>      }
>  }
>
> -static uint64_t gt64120_readl (void *opaque,
> -                               hwaddr addr, unsigned size)
> +static uint64_t gt64120_readl(void *opaque,
> +                              hwaddr addr, unsigned size)
>  {
>      GT64120State *s = opaque;
>      PCIHostState *phb = PCI_HOST_BRIDGE(s);
> @@ -1193,7 +1193,8 @@ PCIBus *gt64120_register(qemu_irq *pic)
>                                       get_system_io(),
>                                       PCI_DEVFN(18, 0), 4, TYPE_PCI_BUS);
>      qdev_init_nofail(dev);
> -    memory_region_init_io(&d->ISD_mem, OBJECT(dev), &isd_mem_ops, d,
"isd-mem", 0x1000);
> +    memory_region_init_io(&d->ISD_mem, OBJECT(dev), &isd_mem_ops, d,
> +                          "isd-mem", 0x1000);
>
>      pci_create_simple(phb->bus, PCI_DEVFN(0, 0), "gt64120_pci");
>      return phb->bus;
> --
> 2.19.1
>
>