[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/66] Hexagon patch series
|
From: |
no-reply |
|
Subject: |
Re: [RFC PATCH 00/66] Hexagon patch series |
|
Date: |
Mon, 10 Feb 2020 17:31:33 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [RFC PATCH 00/66] Hexagon patch series
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7a2b354 Hexagon HVX build infrastructure
f445784 Hexagon HVX translation
876116c Hexagon HVX TCG generation
e77505e Hexagon HVX helper to commit vector stores (masked and scatter/gather)
dc23a1c Hexagon HVX macros referenced in instruction semantics
cc6be78 Hexagon HVX macros to interface with the generator
22f408f Hexagon HVX instruction utility functions
3d4f56a Hexagon HVX instruction decoding
40ec295 Hexagon HVX semantics generator
9c5c895 Hexagon HVX import macro definitions
92dce5d Hexagon HVX import semantics
ffcca92 Hexagon HVX import instruction encodings
d5ebf14 Hexagon HVX support in gdbstub
df47f64 Hexagon - Add Hexagon Vector eXtensions (HVX) to core definition
86f9dd7 Hexagon build infrastructure
4a0112d Hexagon Linux user emulation
b272b70 Hexagon translation
8bfe3f2 Hexagon TCG generation - step 12
03465b3 Hexagon TCG generation - step 11
bca0e86 Hexagon TCG generation - step 10
3d5e67f Hexagon TCG generation - step 09
f382bf5 Hexagon TCG generation - step 08
5ce4437 Hexagon TCG generation - step 07
9d340b5 Hexagon TCG generation - step 06
9d2028e Hexagon TCG generation - step 05
42b2388 Hexagon TCG generation - step 04
cdca413 Hexagon TCG generation - step 03
8841a20 Hexagon TCG generation - step 02
0e7ecc9 Hexagon TCG generation - step 01
efc508d Hexagon TCG generation helpers - step 5
4860b36 Hexagon TCG generation helpers - step 4
bac1a49 Hexagon TCG generation helpers - step 3
803f77c Hexagon TCG generation helpers - step 2
8b842c6 Hexagon TCG generation helpers - step 1
6c5d03d Hexagon instruction classes
21cb791 Hexagon macros referenced in instruction semantics
c26cc78 Hexagon macros to interface with the generator
a9c1282 Hexagon opcode data structures
38f3548 Hexagon generater phase 4 - Decode tree
3d4364b Hexagon generator phase 3 - C preprocessor for decode tree
a25a1a5 Hexagon generator phase 2 - printinsn-generated.h
f0262c4 Hexagon generator phase 2 - op_regs_generated.h
c200b92 Hexagon generator phase 2 - op_attribs_generated.h
55b2d7e Hexagon generator phase 2 - opcodes_def_generated.h
38aac21 Hexagon generator phase 2 - qemu_wrap_generated.h
2c859f2 Hexagon generator phase 2 - qemu_def_generated.h
e149804 Hexagon generator phase 1 - C preprocessor for semantics
2a9b0de Hexagon instruction utility functions
6d20bd9 Hexagon instruction class definitions
9510854 Hexagon arch import - instruction encoding
0b9bf23 Hexagon arch import - macro definitions
53dc5e2 Hexagon arch import - instruction semantics definitions
b8b3fc7 Hexagon instruction printing
4f5c5b2 Hexagon instruction/packet decode
7ec0047 Hexagon register map
2b98b28 Hexagon instruction attributes
d22b29a Hexagon register fields
86ce4af Hexagon architecture types
ea357b9 Hexagon instruction and packet types
c0d62e7 Hexagon GDB Stub
8fdc6fa Hexagon CPU Scalar Core Helpers
edc29eb Hexagon Disassembler
d909607 Hexagon register names
10b1312 Hexagon CPU Scalar Core Definition
52e9d22 Hexagon ELF Machine Definition
950dc7d Hexagon Maintainers
=== OUTPUT BEGIN ===
1/66 Checking commit 950dc7d420ac (Hexagon Maintainers)
2/66 Checking commit 52e9d224e833 (Hexagon ELF Machine Definition)
3/66 Checking commit 10b1312bed65 (Hexagon CPU Scalar Core Definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 584 lines checked
Patch 3/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/66 Checking commit d9096078a0ab (Hexagon register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 97 lines checked
Patch 4/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/66 Checking commit edc29ebfa061 (Hexagon Disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26:
new file mode 100644
ERROR: space prohibited between function name and open parenthesis '('
#95: FILE: include/disas/dis-asm.h:439:
+int print_insn_hexagon (bfd_vma, disassemble_info*);
total: 1 errors, 1 warnings, 70 lines checked
Patch 5/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/66 Checking commit 8fdc6fa51e8a (Hexagon CPU Scalar Core Helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 469 lines checked
Patch 6/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/66 Checking commit c0d62e717802 (Hexagon GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27:
new file mode 100644
total: 0 errors, 1 warnings, 58 lines checked
Patch 7/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/66 Checking commit ea357b91b9cb (Hexagon instruction and packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 133 lines checked
Patch 8/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/66 Checking commit 86ce4afc3459 (Hexagon architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 42 lines checked
Patch 9/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/66 Checking commit d22b29a47e51 (Hexagon register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/reg_fields.h:33:
+#define DEF_REG_FIELD(TAG, NAME, START, WIDTH, DESCRIPTION) \
+ TAG,
total: 1 errors, 1 warnings, 177 lines checked
Patch 10/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/66 Checking commit 2b98b286ca95 (Hexagon instruction attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#37: FILE: target/hexagon/attribs.h:22:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,
total: 1 errors, 1 warnings, 436 lines checked
Patch 11/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/66 Checking commit 7ec004742ef2 (Hexagon register map)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100644
total: 0 errors, 1 warnings, 38 lines checked
Patch 12/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/66 Checking commit 4f5c5b2f679e (Hexagon instruction/packet decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#121: FILE: target/hexagon/decode.c:95:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#901: FILE: target/hexagon/q6v_decode.c:51:
+#define DECODE_OPINFO(TAG, BEH) \
+ case TAG: \
+ { BEH } \
+ break; \
+
total: 2 errors, 1 warnings, 1214 lines checked
Patch 13/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/66 Checking commit b8b3fc71ff35 (Hexagon instruction printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#60: FILE: target/hexagon/printinsn.c:45:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+ case TAG: \
+ snprintf(buf, n, FMT, __VA_ARGS__);\
+ break;
total: 1 errors, 1 warnings, 119 lines checked
Patch 14/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/66 Checking commit 53dc5e206306 (Hexagon arch import - instruction semantics
definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 6262 lines checked
Patch 15/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/66 Checking commit 0b9bf231147a (Hexagon arch import - macro definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100755
total: 0 errors, 1 warnings, 3970 lines checked
Patch 16/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/66 Checking commit 95108542b93a (Hexagon arch import - instruction encoding)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 2558 lines checked
Patch 17/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/66 Checking commit 6d20bd9668f4 (Hexagon instruction class definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 52 lines checked
Patch 18/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/66 Checking commit 2a9b0de6e028 (Hexagon instruction utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#1705: FILE: target/hexagon/fma_emu.c:518:
+ /* result zero */ \
WARNING: Block comments use a leading /* on a separate line
#1713: FILE: target/hexagon/fma_emu.c:526:
+ /* Normalize right */ \
WARNING: Block comments use a leading /* on a separate line
#1714: FILE: target/hexagon/fma_emu.c:527:
+ /* We want MANTBITS bits of mantissa plus the leading one. */ \
WARNING: Block comments use a leading /* on a separate line
#1715: FILE: target/hexagon/fma_emu.c:528:
+ /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \
WARNING: Block comments use a leading /* on a separate line
#1716: FILE: target/hexagon/fma_emu.c:529:
+ /* So we need to normalize right while the high word is non-zero and \
WARNING: Block comments should align the * on each line
#1717: FILE: target/hexagon/fma_emu.c:530:
+ /* So we need to normalize right while the high word is non-zero and \
+ * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \
WARNING: Block comments use a leading /* on a separate line
#1723: FILE: target/hexagon/fma_emu.c:536:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1734: FILE: target/hexagon/fma_emu.c:547:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1741: FILE: target/hexagon/fma_emu.c:554:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1751: FILE: target/hexagon/fma_emu.c:564:
+ /* OK, we're relatively canonical... now we need to round */ \
WARNING: Block comments use a leading /* on a separate line
#1756: FILE: target/hexagon/fma_emu.c:569:
+ /* Chop and we're done */ \
WARNING: Block comments use a leading /* on a separate line
#1770: FILE: target/hexagon/fma_emu.c:583:
+ /* round up if guard is 1, down if guard is zero */ \
WARNING: Block comments use a leading /* on a separate line
#1773: FILE: target/hexagon/fma_emu.c:586:
+ /* exactly .5, round up if odd */ \
WARNING: Block comments use a leading /* on a separate line
#1780: FILE: target/hexagon/fma_emu.c:593:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1790: FILE: target/hexagon/fma_emu.c:603:
+ /* Overflow? */ \
WARNING: Block comments use a leading /* on a separate line
#1792: FILE: target/hexagon/fma_emu.c:605:
+ /* Yep, inf result */ \
WARNING: Block comments use a leading /* on a separate line
#1815: FILE: target/hexagon/fma_emu.c:628:
+ /* Underflow? */ \
WARNING: Block comments use a leading /* on a separate line
#1817: FILE: target/hexagon/fma_emu.c:630:
+ /* Leading one means: No, we're normal. So, we should be done... */ \
total: 0 errors, 19 warnings, 2094 lines checked
Patch 19/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/66 Checking commit e1498047e852 (Hexagon generator phase 1 - C preprocessor
for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
ERROR: suspicious ; after while (0)
#78: FILE: target/hexagon/gen_semantics.c:59:
+ } while (0);
ERROR: suspicious ; after while (0)
#85: FILE: target/hexagon/gen_semantics.c:66:
+ } while (0);
total: 2 errors, 1 warnings, 92 lines checked
Patch 20/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/66 Checking commit 2c859f2e31ea (Hexagon generator phase 2 -
qemu_def_generated.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100755
ERROR: please use python3 interpreter
#21: FILE: target/hexagon/do_qemu.py:1:
+#!/usr/bin/env python
total: 1 errors, 1 warnings, 773 lines checked
Patch 21/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/66 Checking commit 38aac214033b (Hexagon generator phase 2 -
qemu_wrap_generated.h)
23/66 Checking commit 55b2d7ee57f9 (Hexagon generator phase 2 -
opcodes_def_generated.h)
24/66 Checking commit c200b920adee (Hexagon generator phase 2 -
op_attribs_generated.h)
25/66 Checking commit f0262c416b0e (Hexagon generator phase 2 -
op_regs_generated.h)
26/66 Checking commit a25a1a5fb267 (Hexagon generator phase 2 -
printinsn-generated.h)
27/66 Checking commit 3d4364b80632 (Hexagon generator phase 3 - C preprocessor
for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#82: FILE: target/hexagon/gen_dectree_import.c:63:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#91: FILE: target/hexagon/gen_dectree_import.c:72:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,
ERROR: suspicious ; after while (0)
#196: FILE: target/hexagon/gen_dectree_import.c:177:
+ } while (0);
total: 3 errors, 1 warnings, 205 lines checked
Patch 27/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/66 Checking commit 38f354878e1b (Hexagon generater phase 4 - Decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100755
ERROR: please use python3 interpreter
#18: FILE: target/hexagon/dectree.py:1:
+#!/usr/bin/env python
total: 1 errors, 1 warnings, 354 lines checked
Patch 28/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/66 Checking commit a9c12828a0a2 (Hexagon opcode data structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#62: FILE: target/hexagon/opcodes.c:47:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,
ERROR: Macros with complex values should be enclosed in parenthesis
#72: FILE: target/hexagon/opcodes.c:57:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#82: FILE: target/hexagon/opcodes.c:67:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#192: FILE: target/hexagon/opcodes.c:177:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0
total: 4 errors, 1 warnings, 290 lines checked
Patch 29/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/66 Checking commit c26cc7855c0b (Hexagon macros to interface with the
generator)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 388 lines checked
Patch 30/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/66 Checking commit 21cb791e87ca (Hexagon macros referenced in instruction
semantics)
32/66 Checking commit 6c5d03d78e52 (Hexagon instruction classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#159: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE),
ERROR: Macros with complex values should be enclosed in parenthesis
#165: FILE: target/hexagon/iclass.h:33:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE),
total: 2 errors, 1 warnings, 155 lines checked
Patch 32/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/66 Checking commit 8b842c6bae96 (Hexagon TCG generation helpers - step 1)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 323 lines checked
Patch 33/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/66 Checking commit 803f77c188b0 (Hexagon TCG generation helpers - step 2)
35/66 Checking commit bac1a49d71b5 (Hexagon TCG generation helpers - step 3)
36/66 Checking commit 4860b36f7100 (Hexagon TCG generation helpers - step 4)
37/66 Checking commit efc508d11f14 (Hexagon TCG generation helpers - step 5)
38/66 Checking commit 0e7ecc9f6e6d (Hexagon TCG generation - step 01)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 85 lines checked
Patch 38/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/66 Checking commit 8841a205e773 (Hexagon TCG generation - step 02)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25:
new file mode 100644
total: 0 errors, 1 warnings, 411 lines checked
Patch 39/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/66 Checking commit cdca41309a5b (Hexagon TCG generation - step 03)
41/66 Checking commit 42b2388a7c59 (Hexagon TCG generation - step 04)
42/66 Checking commit 9d2028ea87d8 (Hexagon TCG generation - step 05)
43/66 Checking commit 9d340b52603f (Hexagon TCG generation - step 06)
44/66 Checking commit 5ce443777fa5 (Hexagon TCG generation - step 07)
45/66 Checking commit f382bf58bd76 (Hexagon TCG generation - step 08)
46/66 Checking commit 3d5e67f03159 (Hexagon TCG generation - step 09)
47/66 Checking commit bca0e86184c9 (Hexagon TCG generation - step 10)
48/66 Checking commit 03465b36b627 (Hexagon TCG generation - step 11)
49/66 Checking commit 8bfe3f253a63 (Hexagon TCG generation - step 12)
50/66 Checking commit b272b705e025 (Hexagon translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 814 lines checked
Patch 50/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
51/66 Checking commit 4a0112d25d95 (Hexagon Linux user emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 1118 lines checked
Patch 51/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
52/66 Checking commit 86f9dd78305c (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
WARNING: line over 80 characters
#72: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'
ERROR: line over 90 characters
#73: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 2 warnings, 1675 lines checked
Patch 52/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
53/66 Checking commit df47f6485af0 (Hexagon - Add Hexagon Vector eXtensions
(HVX) to core definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#231:
new file mode 100644
total: 0 errors, 1 warnings, 274 lines checked
Patch 53/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
54/66 Checking commit d5ebf1424f5f (Hexagon HVX support in gdbstub)
55/66 Checking commit ffcca926c2c1 (Hexagon HVX import instruction encodings)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 857 lines checked
Patch 55/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
56/66 Checking commit 92dce5d65a9d (Hexagon HVX import semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
total: 0 errors, 1 warnings, 2838 lines checked
Patch 56/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
57/66 Checking commit 9c5c89526c8f (Hexagon HVX import macro definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 1135 lines checked
Patch 57/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
58/66 Checking commit 40ec29548134 (Hexagon HVX semantics generator)
59/66 Checking commit 3d4f56a9ccc5 (Hexagon HVX instruction decoding)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#80:
new file mode 100644
total: 0 errors, 1 warnings, 792 lines checked
Patch 59/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
60/66 Checking commit 22f408ff7edb (Hexagon HVX instruction utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 303 lines checked
Patch 60/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
61/66 Checking commit cc6be785ec5b (Hexagon HVX macros to interface with the
generator)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 232 lines checked
Patch 61/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
62/66 Checking commit dc23a1c1d57f (Hexagon HVX macros referenced in
instruction semantics)
ERROR: suspicious ; after while (0)
#118: FILE: target/hexagon/mmvec/macros.h:332:
+ } while (0);
ERROR: suspicious ; after while (0)
#125: FILE: target/hexagon/mmvec/macros.h:339:
+ } while (0);
total: 2 errors, 0 warnings, 440 lines checked
Patch 62/66 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
63/66 Checking commit e77505e3acac (Hexagon HVX helper to commit vector stores
(masked and scatter/gather))
64/66 Checking commit 876116c3afab (Hexagon HVX TCG generation)
65/66 Checking commit f445784ebe8f (Hexagon HVX translation)
66/66 Checking commit 7a2b354a3898 (Hexagon HVX build infrastructure)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [RFC PATCH 57/66] Hexagon HVX import macro definitions, (continued)
- [RFC PATCH 57/66] Hexagon HVX import macro definitions, Taylor Simpson, 2020/02/10
- [RFC PATCH 59/66] Hexagon HVX instruction decoding, Taylor Simpson, 2020/02/10
- [RFC PATCH 62/66] Hexagon HVX macros referenced in instruction semantics, Taylor Simpson, 2020/02/10
- [RFC PATCH 63/66] Hexagon HVX helper to commit vector stores (masked and scatter/gather), Taylor Simpson, 2020/02/10
- [RFC PATCH 61/66] Hexagon HVX macros to interface with the generator, Taylor Simpson, 2020/02/10
- [RFC PATCH 60/66] Hexagon HVX instruction utility functions, Taylor Simpson, 2020/02/10
- [RFC PATCH 52/66] Hexagon build infrastructure, Taylor Simpson, 2020/02/10
- [RFC PATCH 56/66] Hexagon HVX import semantics, Taylor Simpson, 2020/02/10
- Re: [RFC PATCH 00/66] Hexagon patch series,
no-reply <=
- Re: [RFC PATCH 00/66] Hexagon patch series, Philippe Mathieu-Daudé, 2020/02/11
- Re: [RFC PATCH 00/66] Hexagon patch series, Philippe Mathieu-Daudé, 2020/02/11