Re: [RFC PATCH 00/66] Hexagon patch series

[Philippe Mathieu-Daudé]

On 2/11/20 2:31 AM, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]> ERROR: please use python3 interpreter
> #21: FILE: target/hexagon/do_qemu.py:1:
> +#!/usr/bin/env python

Yay my Perl fu worked \o/

> total: 1 errors, 1 warnings, 773 lines checked
>
> Patch 21/66 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 22/66 Checking commit 38aac214033b (Hexagon generator phase 2 - 
> qemu_wrap_generated.h)
> 23/66 Checking commit 55b2d7ee57f9 (Hexagon generator phase 2 - 
> opcodes_def_generated.h)
> 24/66 Checking commit c200b920adee (Hexagon generator phase 2 - 
> op_attribs_generated.h)
> 25/66 Checking commit f0262c416b0e (Hexagon generator phase 2 - 
> op_regs_generated.h)
> 26/66 Checking commit a25a1a5fb267 (Hexagon generator phase 2 - 
> printinsn-generated.h)
> 27/66 Checking commit 3d4364b80632 (Hexagon generator phase 3 - C preprocessor 
> for decode tree)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #15:
> new file mode 100644
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #82: FILE: target/hexagon/gen_dectree_import.c:63:
> +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #91: FILE: target/hexagon/gen_dectree_import.c:72:
> +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,
>
> ERROR: suspicious ; after while (0)
> #196: FILE: target/hexagon/gen_dectree_import.c:177:
> +    } while (0);
>
> total: 3 errors, 1 warnings, 205 lines checked
>
> Patch 27/66 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 28/66 Checking commit 38f354878e1b (Hexagon generater phase 4 - Decode tree)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #13:
> new file mode 100755
>
> ERROR: please use python3 interpreter
> #18: FILE: target/hexagon/dectree.py:1:
> +#!/usr/bin/env python
>
> total: 1 errors, 1 warnings, 354 lines checked
[...]