Re: [PATCH 1/4] hw/hppa/dino: Add comments with register name

[Helge Deller]

On 14.02.20 00:41, Philippe Mathieu-Daudé wrote:
> Add a comment with the name of each register in the 0x800-0x833 range.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Acked-by: Helge Deller <address@hidden>

> ---
>  hw/hppa/dino.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index 9797a7f0d9..c237ad3b1b 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -85,18 +85,18 @@
>
>  #define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4)
>  static const uint32_t reg800_keep_bits[DINO800_REGS] = {
> -            MAKE_64BIT_MASK(0, 1),
> -            MAKE_64BIT_MASK(0, 7),
> -            MAKE_64BIT_MASK(0, 7),
> -            MAKE_64BIT_MASK(0, 8),
> -            MAKE_64BIT_MASK(0, 7),
> -            MAKE_64BIT_MASK(0, 9),
> -            MAKE_64BIT_MASK(0, 32),
> -            MAKE_64BIT_MASK(0, 8),
> -            MAKE_64BIT_MASK(0, 30),
> -            MAKE_64BIT_MASK(0, 25),
> -            MAKE_64BIT_MASK(0, 22),
> -            MAKE_64BIT_MASK(0, 9),
> +    MAKE_64BIT_MASK(0, 1),  /* GMASK */
> +    MAKE_64BIT_MASK(0, 7),  /* PAMR */
> +    MAKE_64BIT_MASK(0, 7),  /* PAPR */
> +    MAKE_64BIT_MASK(0, 8),  /* DAMODE */
> +    MAKE_64BIT_MASK(0, 7),  /* PCICMD */
> +    MAKE_64BIT_MASK(0, 9),  /* PCISTS */
> +    MAKE_64BIT_MASK(0, 32), /* Undefined */
> +    MAKE_64BIT_MASK(0, 8),  /* MLTIM */
> +    MAKE_64BIT_MASK(0, 30), /* BRDG_FEAT */
> +    MAKE_64BIT_MASK(0, 25), /* PCIROR */
> +    MAKE_64BIT_MASK(0, 22), /* PCIWOR */
> +    MAKE_64BIT_MASK(0, 9),  /* TLTIM */
>  };
>
>  typedef struct DinoState {
>