Re: [RFC PATCH 3/4] hw/hppa/dino: Fix PCIROR register access bitmask

[Helge Deller]

On 14.02.20 00:41, Philippe Mathieu-Daudé wrote:
> Only 24 bits of the PCIROR register are documented
> (see pp. 37 of datasheet referenced in this file header).
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Acked-by: Helge Deller <address@hidden>

> ---
>  hw/hppa/dino.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index 8868e31793..be799aad43 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -94,7 +94,7 @@ static const uint32_t reg800_keep_bits[DINO800_REGS] = {
>      MAKE_64BIT_MASK(0, 32), /* Undefined */
>      MAKE_64BIT_MASK(0, 8),  /* MLTIM */
>      MAKE_64BIT_MASK(0, 30), /* BRDG_FEAT */
> -    MAKE_64BIT_MASK(0, 25), /* PCIROR */
> +    MAKE_64BIT_MASK(0, 24), /* PCIROR */
>      MAKE_64BIT_MASK(0, 22), /* PCIWOR */
>      MAKE_64BIT_MASK(0, 32), /* Undocumented */
>      MAKE_64BIT_MASK(0, 9),  /* TLTIM */
>