[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] hw/display/artist: Move trace event to draw_line()
From: |
Richard Henderson |
Subject: |
[PULL 1/9] hw/display/artist: Move trace event to draw_line() |
Date: |
Tue, 18 Feb 2020 11:39:21 -0800 |
From: Philippe Mathieu-Daudé <address@hidden>
Instead of emitting the trace event before each call to
draw_line(), call it once at draw_line() entrance.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Sven Schnelle <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/display/artist.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 65be9e3554..abacb0e27d 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -563,6 +563,7 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
bool c1;
uint8_t *p;
+ trace_artist_draw_line(x1, y1, x2, y2);
if (update_start) {
s->vram_start = (x2 << 16) | y2;
@@ -654,7 +655,6 @@ static void draw_line_pattern_start(ARTISTState *s)
int endy = artist_get_y(s->blockmove_size);
int pstart = s->line_pattern_start >> 16;
- trace_artist_draw_line(startx, starty, endx, endy);
draw_line(s, startx, starty, endx, endy, false, -1, pstart);
s->line_pattern_skip = pstart;
}
@@ -668,7 +668,6 @@ static void draw_line_pattern_next(ARTISTState *s)
int endy = artist_get_y(s->blockmove_size);
int line_xy = s->line_xy >> 16;
- trace_artist_draw_line(startx, starty, endx, endy);
draw_line(s, startx, starty, endx, endy, false, s->line_pattern_skip,
s->line_pattern_skip + line_xy);
s->line_pattern_skip += line_xy;
@@ -683,7 +682,6 @@ static void draw_line_size(ARTISTState *s, bool
update_start)
int endx = artist_get_x(s->line_size);
int endy = artist_get_y(s->line_size);
- trace_artist_draw_line(startx, starty, endx, endy);
draw_line(s, startx, starty, endx, endy, update_start, -1, -1);
}
@@ -743,7 +741,6 @@ static void draw_line_xy(ARTISTState *s, bool update_start)
return;
}
- trace_artist_draw_line(startx, starty, endx, endy);
draw_line(s, startx, starty, endx, endy, false, -1, -1);
}
@@ -755,7 +752,6 @@ static void draw_line_end(ARTISTState *s, bool update_start)
int endx = artist_get_x(s->line_end);
int endy = artist_get_y(s->line_end);
- trace_artist_draw_line(startx, starty, endx, endy);
draw_line(s, startx, starty, endx, endy, update_start, -1, -1);
}
--
2.20.1
- [PULL 0/9] target/hppa patch queue, Richard Henderson, 2020/02/18
- [PULL 1/9] hw/display/artist: Move trace event to draw_line(),
Richard Henderson <=
- [PULL 2/9] hw/display/artist: Remove pointless initialization, Richard Henderson, 2020/02/18
- [PULL 3/9] hw/display/artist: Delay some variables initialization, Richard Henderson, 2020/02/18
- [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display, Richard Henderson, 2020/02/18
- [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389), Richard Henderson, 2020/02/18
- [PULL 6/9] hw/hppa/dino: Add comments with register name, Richard Henderson, 2020/02/18
- [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394), Richard Henderson, 2020/02/18
- [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register, Richard Henderson, 2020/02/18
- [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c, Richard Henderson, 2020/02/18
- Re: [PULL 0/9] target/hppa patch queue, Peter Maydell, 2020/02/20