[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] hw/display/artist: Remove pointless initialization
From: |
Richard Henderson |
Subject: |
[PULL 2/9] hw/display/artist: Remove pointless initialization |
Date: |
Tue, 18 Feb 2020 11:39:22 -0800 |
From: Philippe Mathieu-Daudé <address@hidden>
We are initializating incy inconditionally:
if (y1 <= y2) {
incy = 1;
} else {
incy = -1;
}
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Sven Schnelle <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/display/artist.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index abacb0e27d..47f0e9f0bc 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -572,7 +572,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
buf = &s->vram_buffer[ARTIST_BUFFER_AP];
c1 = false;
- incy = 1;
if (x2 > x1) {
dx = x2 - x1;
--
2.20.1
- [PULL 0/9] target/hppa patch queue, Richard Henderson, 2020/02/18
- [PULL 1/9] hw/display/artist: Move trace event to draw_line(), Richard Henderson, 2020/02/18
- [PULL 2/9] hw/display/artist: Remove pointless initialization,
Richard Henderson <=
- [PULL 3/9] hw/display/artist: Delay some variables initialization, Richard Henderson, 2020/02/18
- [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display, Richard Henderson, 2020/02/18
- [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389), Richard Henderson, 2020/02/18
- [PULL 6/9] hw/hppa/dino: Add comments with register name, Richard Henderson, 2020/02/18
- [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394), Richard Henderson, 2020/02/18
- [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register, Richard Henderson, 2020/02/18
- [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c, Richard Henderson, 2020/02/18
- Re: [PULL 0/9] target/hppa patch queue, Peter Maydell, 2020/02/20