Re: [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec

[Andrzej Jakowski]

On 2/18/20 6:07 PM, address@hidden wrote:
> === TEST SCRIPT BEGIN ===
> #! /bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-mingw@fedora J=14 NETWORK=1
> === TEST SCRIPT END ===
> 
>   CC      hw/display/sii9022.o
>   CC      hw/display/ssd0303.o
> /tmp/qemu-test/src/hw/block/nvme.c: In function 'nvme_pmr_read':
> /tmp/qemu-test/src/hw/block/nvme.c:1342:15: error: implicit declaration of 
> function 'msync'; did you mean 'fsync'? 
> [-Werror=implicit-function-declaration]
>          ret = msync(n->pmrbuf, n->f_pmr_size, MS_SYNC);
>                ^~~~~
>                fsync
> /tmp/qemu-test/src/hw/block/nvme.c:1342:15: error: nested extern declaration 
> of 'msync' [-Werror=nested-externs]
> /tmp/qemu-test/src/hw/block/nvme.c:1342:47: error: 'MS_SYNC' undeclared 
> (first use in this function)
>          ret = msync(n->pmrbuf, n->f_pmr_size, MS_SYNC);
>                                                ^~~~~~~
> /tmp/qemu-test/src/hw/block/nvme.c:1342:47: note: each undeclared identifier 
> is reported only once for each function it appears in
> /tmp/qemu-test/src/hw/block/nvme.c: In function 'nvme_realize':
> /tmp/qemu-test/src/hw/block/nvme.c:1413:21: error: implicit declaration of 
> function 'mmap'; did you mean 'max'? [-Werror=implicit-function-declaration]
>          n->pmrbuf = mmap(NULL, n->f_pmr_size,
>                      ^~~~

This patch seems to fail on cross-compilation for Windows env.
I plan to submit second version of this patch which will conditionally
support PMR for Linux environment only. It should take care of this problem.

Do you see any better fix for that?