[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/16] machine: Add SMP Sockets in CpuTopology
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 05/16] machine: Add SMP Sockets in CpuTopology |
Date: |
Mon, 24 Feb 2020 09:37:42 +0100 |
On Thu, 13 Feb 2020 12:16:58 -0600
Babu Moger <address@hidden> wrote:
> Store the smp sockets in CpuTopology. The socket information required to
> build the apic id in EPYC mode. Right now socket information is not passed
> to down when decoding the apic id. Add the socket information here.
>
> Signed-off-by: Babu Moger <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/core/machine.c | 1 +
> hw/i386/pc.c | 1 +
> include/hw/boards.h | 2 ++
> vl.c | 1 +
> 4 files changed, 5 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 023548b4f3..ea03c25565 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -789,6 +789,7 @@ static void smp_parse(MachineState *ms, QemuOpts *opts)
> ms->smp.cpus = cpus;
> ms->smp.cores = cores;
> ms->smp.threads = threads;
> + ms->smp.sockets = sockets;
> }
>
> if (ms->smp.cpus > 1) {
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 9803413dd9..f13721ac43 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -978,6 +978,7 @@ void pc_smp_parse(MachineState *ms, QemuOpts *opts)
> ms->smp.cpus = cpus;
> ms->smp.cores = cores;
> ms->smp.threads = threads;
> + ms->smp.sockets = sockets;
> x86ms->smp_dies = dies;
> }
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 24cbeecbae..a50a2d779e 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -256,12 +256,14 @@ typedef struct DeviceMemoryState {
> * @cpus: the number of present logical processors on the machine
> * @cores: the number of cores in one package
> * @threads: the number of threads in one core
> + * @sockets: the number of sockets on the machine
> * @max_cpus: the maximum number of logical processors on the machine
> */
> typedef struct CpuTopology {
> unsigned int cpus;
> unsigned int cores;
> unsigned int threads;
> + unsigned int sockets;
> unsigned int max_cpus;
> } CpuTopology;
>
> diff --git a/vl.c b/vl.c
> index 94508300c3..3f6d396a95 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3819,6 +3819,7 @@ int main(int argc, char **argv, char **envp)
> current_machine->smp.max_cpus = machine_class->default_cpus;
> current_machine->smp.cores = 1;
> current_machine->smp.threads = 1;
> + current_machine->smp.sockets = 1;
>
> machine_class->smp_parse(current_machine,
> qemu_opts_find(qemu_find_opts("smp-opts"), NULL));
>
>
[PATCH v4 05/16] machine: Add SMP Sockets in CpuTopology, Babu Moger, 2020/02/13
- Re: [PATCH v4 05/16] machine: Add SMP Sockets in CpuTopology,
Igor Mammedov <=
[PATCH v4 06/16] hw/i386: Update structures for nodes_per_pkg, Babu Moger, 2020/02/13
[PATCH v4 07/16] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids, Babu Moger, 2020/02/13
[PATCH v4 08/16] hw/386: Add EPYC mode topology decoding functions, Babu Moger, 2020/02/13
[PATCH v4 09/16] target/i386: Cleanup and use the EPYC mode topology functions, Babu Moger, 2020/02/13